[DURACOM-359] fix matomo downloading its .js even if it's disabled

Author: Andrea Barbasso

src/app/statistics/matomo.service.spec.ts

@@ -23,6 +23,7 @@ import {
   createSuccessfulRemoteDataObject$,
 } from '../shared/remote-data.utils';
 import {
+  MATOMO_ENABLED,
   MATOMO_SITE_ID,
   MATOMO_TRACKER_URL,
   MatomoService,
@@ -84,6 +85,9 @@ describe('MatomoService', () => {
     configService.findByPropertyName.withArgs(MATOMO_TRACKER_URL).and.returnValue(
       createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(),{ values: ['http://matomo'] })),
     );
+    configService.findByPropertyName.withArgs(MATOMO_ENABLED).and.returnValue(
+      createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(),{ values: ['true'] })),
+    );
     configService.findByPropertyName.withArgs(MATOMO_SITE_ID).and.returnValue(
       createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(), { values: ['1'] })));
     orejimeService.getSavedPreferences.and.returnValue(of({ matomo: true }));
@@ -102,6 +106,9 @@ describe('MatomoService', () => {
     configService.findByPropertyName.withArgs(MATOMO_TRACKER_URL).and.returnValue(
       createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(),{ values: ['http://example.com'] })),
     );
+    configService.findByPropertyName.withArgs(MATOMO_ENABLED).and.returnValue(
+      createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(),{ values: ['true'] })),
+    );
     configService.findByPropertyName.withArgs(MATOMO_SITE_ID).and.returnValue(
       createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(), { values: ['1'] })));
     orejimeService.getSavedPreferences.and.returnValue(of({ matomo: true }));
@@ -123,6 +130,24 @@ describe('MatomoService', () => {
     expect(matomoInitializer.initializeTracker).not.toHaveBeenCalled();
   });
 
+  it('should not initialize tracker if matomo is disabled', () => {
+    environment.production = true;
+    environment.matomo = { trackerUrl: '' };
+    configService.findByPropertyName.withArgs(MATOMO_TRACKER_URL).and.returnValue(
+      createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(),{ values: ['http://example.com'] })),
+    );
+    configService.findByPropertyName.withArgs(MATOMO_ENABLED).and.returnValue(
+      createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(),{ values: ['false'] })),
+    );
+    configService.findByPropertyName.withArgs(MATOMO_SITE_ID).and.returnValue(
+      createSuccessfulRemoteDataObject$(Object.assign(new ConfigurationProperty(), { values: ['1'] })));
+    orejimeService.getSavedPreferences.and.returnValue(of({ matomo: true }));
+
+    service.init();
+
+    expect(matomoInitializer.initializeTracker).not.toHaveBeenCalled();
+  });
+
   describe('with visitorId set', () => {
     beforeEach(() => {
       matomoTracker.getVisitorId.and.returnValue(Promise.resolve('12345'));

src/app/statistics/matomo.service.ts

@@ -77,10 +77,10 @@ export class MatomoService {
       preferences$
         .pipe(
           tap(preferences => this.changeMatomoConsent(preferences?.matomo)),
-          switchMap(_ => combineLatest([this.getSiteId$(), this.getTrackerUrl$()])),
+          switchMap(_ => combineLatest([this.isMatomoEnabled$(), this.getSiteId$(), this.getTrackerUrl$()])),
         )
-        .subscribe(([siteId, trackerUrl]) => {
-          if (siteId && trackerUrl) {
+        .subscribe(([isMatomoEnabled, siteId, trackerUrl]) => {
+          if (isMatomoEnabled && siteId && trackerUrl) {
             this.matomoInitializer.initializeTracker({ siteId, trackerUrl });
           }
         });