132007: Auto-fixed the ng generate @angular/core:control-flow issues

alexandrevryghem · alexandrevryghem · commit e3b54056982e · 2025-07-08T12:51:31.000+02:00
diff --git a/src/app/browse-by/browse-by-geospatial-data/browse-by-geospatial-data.component.ts b/src/app/browse-by/browse-by-geospatial-data/browse-by-geospatial-data.component.ts
@@ -1,7 +1,6 @@
 import {
   AsyncPipe,
   isPlatformBrowser,
-  NgIf,
 } from '@angular/common';
 import {
   ChangeDetectionStrategy,
@@ -47,7 +46,6 @@ import { PaginatedSearchOptions } from '../../shared/search/models/paginated-sea
   imports: [
     AsyncPipe,
     GeospatialMapComponent,
-    NgIf,
     TranslateModule,
   ],
   standalone: true,
diff --git a/src/app/item-page/bitstreams/request-a-copy/altcha-captcha.component.ts b/src/app/item-page/bitstreams/request-a-copy/altcha-captcha.component.ts
@@ -1,7 +1,3 @@
-import {
-  AsyncPipe,
-  NgIf,
-} from '@angular/common';
 import {
   Component,
   CUSTOM_ELEMENTS_SCHEMA,
@@ -11,21 +7,14 @@ import {
   Output,
 } from '@angular/core';
 import { ReactiveFormsModule } from '@angular/forms';
-import { RouterLink } from '@angular/router';
 import { TranslateModule } from '@ngx-translate/core';
 
-import { VarDirective } from '../../../shared/utils/var.directive';
-
 @Component({
   selector: 'ds-altcha-captcha',
   templateUrl: './altcha-captcha.component.html',
   imports: [
-    AsyncPipe,
-    NgIf,
     ReactiveFormsModule,
-    RouterLink,
     TranslateModule,
-    VarDirective,
   ],
   schemas: [CUSTOM_ELEMENTS_SCHEMA],
   standalone: true,
diff --git a/src/app/item-page/edit-item-page/item-bitstreams/item-bitstreams.component.ts b/src/app/item-page/edit-item-page/item-bitstreams/item-bitstreams.component.ts
@@ -1,6 +1,6 @@
 import {
   AsyncPipe,
-  CommonModule,
+  NgClass,
 } from '@angular/common';
 import {
   ChangeDetectorRef,
@@ -72,8 +72,8 @@ import { ItemEditBitstreamBundleComponent } from './item-edit-bitstream-bundle/i
     AlertComponent,
     AsyncPipe,
     BtnDisabledDirective,
-    CommonModule,
     ItemEditBitstreamBundleComponent,
+    NgClass,
     RouterLink,
     ThemedLoadingComponent,
     TranslateModule,
diff --git a/src/app/item-page/orcid-page/orcid-page.component.ts b/src/app/item-page/orcid-page/orcid-page.component.ts
@@ -1,5 +1,5 @@
 import {
-  CommonModule,
+  AsyncPipe,
   isPlatformBrowser,
 } from '@angular/common';
 import {
@@ -54,7 +54,7 @@ import { OrcidSyncSettingsComponent } from './orcid-sync-settings/orcid-sync-set
   styleUrls: ['./orcid-page.component.scss'],
   imports: [
     AlertComponent,
-    CommonModule,
+    AsyncPipe,
     OrcidAuthComponent,
     OrcidQueueComponent,
     OrcidSyncSettingsComponent,
diff --git a/src/app/item-page/simple/field-components/specific-field/geospatial/geospatial-item-page-field.component.ts b/src/app/item-page/simple/field-components/specific-field/geospatial/geospatial-item-page-field.component.ts
@@ -1,10 +1,9 @@
-import { NgIf } from '@angular/common';
 import {
   Component,
   Input,
   OnInit,
 } from '@angular/core';
-import { TranslateModule } from '@ngx-translate/core';
+import { TranslatePipe } from '@ngx-translate/core';
 
 import { Item } from '../../../../../core/shared/item.model';
 import {
@@ -21,8 +20,7 @@ import { ItemPageFieldComponent } from '../item-page-field.component';
   imports: [
     GeospatialMapComponent,
     MetadataFieldWrapperComponent,
-    NgIf,
-    TranslateModule,
+    TranslatePipe,
   ],
   standalone: true,
 })
diff --git a/src/app/request-copy/grant-request-copy/grant-request-copy.component.ts b/src/app/request-copy/grant-request-copy/grant-request-copy.component.ts
@@ -1,7 +1,4 @@
-import {
-  AsyncPipe,
-  CommonModule,
-} from '@angular/common';
+import { AsyncPipe } from '@angular/common';
 import {
   Component,
   OnInit,
@@ -49,7 +46,6 @@ import { ThemedEmailRequestCopyComponent } from '../email-request-copy/themed-em
   standalone: true,
   imports: [
     AsyncPipe,
-    CommonModule,
     FormsModule,
     RouterLink,
     ThemedEmailRequestCopyComponent,
diff --git a/src/app/shared/object-geospatial-map/object-geospatial-map.component.ts b/src/app/shared/object-geospatial-map/object-geospatial-map.component.ts
@@ -1,7 +1,4 @@
-import {
-  isPlatformBrowser,
-  NgIf,
-} from '@angular/common';
+import { isPlatformBrowser } from '@angular/common';
 import {
   ChangeDetectionStrategy,
   Component,
@@ -35,7 +32,6 @@ import { parseGeoJsonFromMetadataValue } from '../utils/geospatial.functions';
   standalone: true,
   imports: [
     GeospatialMapComponent,
-    NgIf,
   ],
 })
 
diff --git a/src/app/submission/form/footer/submission-form-footer.component.ts b/src/app/submission/form/footer/submission-form-footer.component.ts
@@ -1,12 +1,12 @@
-import { CommonModule } from '@angular/common';
+import { AsyncPipe } from '@angular/common';
 import {
   Component,
   Input,
   OnChanges,
   SimpleChanges,
 } from '@angular/core';
 import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
-import { TranslateModule } from '@ngx-translate/core';
+import { TranslatePipe } from '@ngx-translate/core';
 import {
   Observable,
   of,
@@ -29,10 +29,10 @@ import { SubmissionService } from '../../submission.service';
   templateUrl: './submission-form-footer.component.html',
   standalone: true,
   imports: [
+    AsyncPipe,
     BrowserOnlyPipe,
     BtnDisabledDirective,
-    CommonModule,
-    TranslateModule,
+    TranslatePipe,
   ],
 })
 export class SubmissionFormFooterComponent implements OnChanges {
diff --git a/src/app/thumbnail/thumbnail.component.html b/src/app/thumbnail/thumbnail.component.html
@@ -1,30 +1,29 @@
 <div class="thumbnail" [class.limit-width]="limitWidth">
   @if (isLoading()) {
-  <div class="thumbnail-content outer">
-    <div class="inner">
-      <div class="centered">
-        <ds-loading [spinner]="true"></ds-loading>
+    <div class="thumbnail-content outer">
+      <div class="inner">
+        <div class="centered">
+          <ds-loading [spinner]="true"></ds-loading>
+        </div>
       </div>
     </div>
-  </div>
   }
   <!-- don't use *ngIf="!isLoading" so the thumbnail can load in while the animation is playing -->
   @if (src() !== null) {
-  <img
-    class="thumbnail-content img-fluid"
-    [ngClass]="{ 'd-none': isLoading ()}"
+    <img class="thumbnail-content img-fluid"
+         [class.d-none]="isLoading"
          [src]="src() | dsSafeUrl"
          [alt]="alt | translate"
          (error)="errorHandler()"
-         (load)="successHandler()"
-  />
-  } @if (src() === null && isLoading() === false) {
-  <div class="thumbnail-content outer">
-    <div class="inner">
-      <div class="thumbnail-placeholder centered">
-        {{ placeholder | translate }}
+         (load)="successHandler()"/>
+  }
+  @if (src() === null && isLoading() === false) {
+    <div class="thumbnail-content outer">
+      <div class="inner">
+        <div class="thumbnail-placeholder centered">
+          {{ placeholder | translate }}
+        </div>
       </div>
     </div>
-  </div>
   }
 </div>
diff --git a/src/app/thumbnail/thumbnail.component.ts b/src/app/thumbnail/thumbnail.component.ts
@@ -1,7 +1,4 @@
-import {
-  CommonModule,
-  isPlatformBrowser,
-} from '@angular/common';
+import { isPlatformBrowser } from '@angular/common';
 import {
   Component,
   Inject,
@@ -12,7 +9,7 @@ import {
   SimpleChanges,
   WritableSignal,
 } from '@angular/core';
-import { TranslateModule } from '@ngx-translate/core';
+import { TranslatePipe } from '@ngx-translate/core';
 import { of } from 'rxjs';
 import { switchMap } from 'rxjs/operators';
 
@@ -40,10 +37,9 @@ import { SafeUrlPipe } from '../shared/utils/safe-url-pipe';
   templateUrl: './thumbnail.component.html',
   standalone: true,
   imports: [
-    CommonModule,
     SafeUrlPipe,
     ThemedLoadingComponent,
-    TranslateModule,
+    TranslatePipe,
   ],
 })
 export class ThumbnailComponent implements OnChanges {
diff --git a/src/app/workflowitems-edit-page/advanced-workflow-action/advanced-workflow-action-select-reviewer/advanced-workflow-action-select-reviewer.component.ts b/src/app/workflowitems-edit-page/advanced-workflow-action/advanced-workflow-action-select-reviewer/advanced-workflow-action-select-reviewer.component.ts
@@ -1,6 +1,7 @@
 import {
-  CommonModule,
+  AsyncPipe,
   Location,
+  NgClass,
 } from '@angular/common';
 import {
   Component,
@@ -44,8 +45,9 @@ export const ADVANCED_WORKFLOW_ACTION_SELECT_REVIEWER = 'selectrevieweraction';
   templateUrl: './advanced-workflow-action-select-reviewer.component.html',
   styleUrls: ['./advanced-workflow-action-select-reviewer.component.scss'],
   imports: [
-    CommonModule,
+    AsyncPipe,
     ModifyItemOverviewComponent,
+    NgClass,
     ReviewersListComponent,
     TranslateModule,
   ],
diff --git a/src/app/workflowitems-edit-page/workflow-item-delete/workflow-item-delete.component.ts b/src/app/workflowitems-edit-page/workflow-item-delete/workflow-item-delete.component.ts
@@ -1,5 +1,5 @@
 import {
-  CommonModule,
+  AsyncPipe,
   Location,
 } from '@angular/common';
 import { Component } from '@angular/core';
@@ -8,7 +8,7 @@ import {
   Router,
 } from '@angular/router';
 import {
-  TranslateModule,
+  TranslatePipe,
   TranslateService,
 } from '@ngx-translate/core';
 import { Observable } from 'rxjs';
@@ -30,9 +30,9 @@ import { WorkflowItemActionPageDirective } from '../workflow-item-action-page.co
   templateUrl: '../workflow-item-action-page.component.html',
   standalone: true,
   imports: [
-    CommonModule,
+    AsyncPipe,
     ModifyItemOverviewComponent,
-    TranslateModule,
+    TranslatePipe,
     VarDirective,
   ],
 })
diff --git a/src/app/workspaceitems-edit-page/workspaceitems-delete-page/workspaceitems-delete-page.component.ts b/src/app/workspaceitems-edit-page/workspaceitems-delete-page/workspaceitems-delete-page.component.ts
@@ -1,5 +1,5 @@
 import {
-  CommonModule,
+  AsyncPipe,
   Location,
 } from '@angular/common';
 import {
@@ -42,7 +42,7 @@ import { NotificationsService } from '../../shared/notifications/notifications.s
   templateUrl: './workspaceitems-delete-page.component.html',
   styleUrls: ['./workspaceitems-delete-page.component.scss'],
   imports: [
-    CommonModule,
+    AsyncPipe,
     ModifyItemOverviewComponent,
     TranslateModule,
   ],
diff --git a/src/themes/custom/app/request-copy/grant-request-copy/grant-request-copy.component.ts b/src/themes/custom/app/request-copy/grant-request-copy/grant-request-copy.component.ts
@@ -1,7 +1,4 @@
-import {
-  AsyncPipe,
-  CommonModule,
-} from '@angular/common';
+import { AsyncPipe } from '@angular/common';
 import { Component } from '@angular/core';
 import { FormsModule } from '@angular/forms';
 import { RouterLink } from '@angular/router';
@@ -21,7 +18,6 @@ import { VarDirective } from '../../../../../app/shared/utils/var.directive';
   standalone: true,
   imports: [
     AsyncPipe,
-    CommonModule,
     FormsModule,
     RouterLink,
     ThemedEmailRequestCopyComponent,
diff --git a/src/themes/custom/app/submission/form/footer/submission-form-footer.component.ts b/src/themes/custom/app/submission/form/footer/submission-form-footer.component.ts
@@ -1,6 +1,6 @@
-import { CommonModule } from '@angular/common';
+import { AsyncPipe } from '@angular/common';
 import { Component } from '@angular/core';
-import { TranslateModule } from '@ngx-translate/core';
+import { TranslatePipe } from '@ngx-translate/core';
 
 import { BtnDisabledDirective } from '../../../../../../app/shared/btn-disabled.directive';
 import { BrowserOnlyPipe } from '../../../../../../app/shared/utils/browser-only.pipe';
@@ -14,10 +14,10 @@ import { SubmissionFormFooterComponent as BaseComponent } from '../../../../../.
   templateUrl: '../../../../../../app/submission/form/footer/submission-form-footer.component.html',
   standalone: true,
   imports: [
+    AsyncPipe,
     BrowserOnlyPipe,
     BtnDisabledDirective,
-    CommonModule,
-    TranslateModule,
+    TranslatePipe,
   ],
 })
 export class SubmissionFormFooterComponent extends BaseComponent {
diff --git a/src/themes/custom/app/thumbnail/thumbnail.component.ts b/src/themes/custom/app/thumbnail/thumbnail.component.ts
@@ -1,6 +1,5 @@
-import { CommonModule } from '@angular/common';
 import { Component } from '@angular/core';
-import { TranslateModule } from '@ngx-translate/core';
+import { TranslatePipe } from '@ngx-translate/core';
 
 import { ThemedLoadingComponent } from '../../../../app/shared/loading/themed-loading.component';
 import { SafeUrlPipe } from '../../../../app/shared/utils/safe-url-pipe';
@@ -14,10 +13,9 @@ import { ThumbnailComponent as BaseComponent } from '../../../../app/thumbnail/t
   templateUrl: '../../../../app/thumbnail/thumbnail.component.html',
   standalone: true,
   imports: [
-    CommonModule,
     SafeUrlPipe,
     ThemedLoadingComponent,
-    TranslateModule,
+    TranslatePipe,
   ],
 })
 export class ThumbnailComponent extends BaseComponent {
diff --git a/src/themes/custom/app/workflowitems-edit-page/workflow-item-delete/workflow-item-delete.component.ts b/src/themes/custom/app/workflowitems-edit-page/workflow-item-delete/workflow-item-delete.component.ts
@@ -1,6 +1,6 @@
-import { CommonModule } from '@angular/common';
+import { AsyncPipe } from '@angular/common';
 import { Component } from '@angular/core';
-import { TranslateModule } from '@ngx-translate/core';
+import { TranslatePipe } from '@ngx-translate/core';
 
 import { ModifyItemOverviewComponent } from '../../../../../app/item-page/edit-item-page/modify-item-overview/modify-item-overview.component';
 import { VarDirective } from '../../../../../app/shared/utils/var.directive';
@@ -13,9 +13,9 @@ import { WorkflowItemDeleteComponent as BaseComponent } from '../../../../../app
   templateUrl: '../../../../../app/workflowitems-edit-page/workflow-item-action-page.component.html',
   standalone: true,
   imports: [
-    CommonModule,
+    AsyncPipe,
     ModifyItemOverviewComponent,
-    TranslateModule,
+    TranslatePipe,
     VarDirective,
   ],
 })
diff --git a/src/themes/custom/app/workspaceitems-edit-page/workspaceitems-delete-page/workspaceitems-delete-page.component.ts b/src/themes/custom/app/workspaceitems-edit-page/workspaceitems-delete-page/workspaceitems-delete-page.component.ts
