Skip to content

Commit f00eae6

Browse files
andreaNekiandreaNeki
authored andcommitted
Code refactoring - Accessibility on the new user registration and forgotten password forms
1 parent 0eb2d5c commit f00eae6

File tree

4 files changed

+15
-7
lines changed

4 files changed

+15
-7
lines changed

src/app/register-email-form/register-email-form.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ <h1>{{MESSAGE_PREFIX + '.header'|translate}}</h1>
1515
for="email">{{MESSAGE_PREFIX + '.email' | translate}}</label>
1616
<input [className]="(email.invalid) && (email.dirty || email.touched) ? 'form-control is-invalid' :'form-control'"
1717
type="text" id="email" formControlName="email"
18-
[attr.aria-label]="'register-email.aria.label'|translate"
18+
[attr.aria-label]="MESSAGE_PREFIX + '.aria.label' | translate"
1919
aria-describedby="email-errors-required email-error-not-valid"
20-
[attr.aria-invalid]="form.get('email')?.invalid"/>
20+
[attr.aria-invalid]="email.invalid"/>
2121
<div *ngIf="email.invalid && (email.dirty || email.touched)"
2222
class="invalid-feedback show-feedback">
2323
<span *ngIf="email.errors && email.errors.required" id="email-errors-required">

src/assets/i18n/en.json5

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6740,5 +6740,7 @@
67406740

67416741
"browse.search-form.placeholder": "Search the repository",
67426742

6743-
"register-email.aria.label": "Enter your e-mail address",
6743+
"register-page.registration.aria.label": "Enter your e-mail address",
6744+
6745+
"forgot-email.form.aria.label": "Enter your e-mail address",
67446746
}

src/assets/i18n/es.json5

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8152,8 +8152,11 @@
81528152
//"browse.search-form.placeholder": "Search the repository",
81538153
"browse.search-form.placeholder": "Buscar en el repositorio",
81548154

8155-
// "register-email.aria.label": "Enter your e-mail address",
8156-
"register-email.aria.label": "Introduzca su dirección de correo electrónico",
8155+
// "register-page.registration.aria.label": "Enter your e-mail address",
8156+
"register-page.registration.aria.label": "Introduzca su dirección de correo electrónico",
8157+
8158+
// "forgot-email.form.aria.label": "Enter your e-mail address",
8159+
"forgot-email.form.aria.label": "Introduzca su dirección de correo electrónico",
81578160

81588161

81598162
}

src/assets/i18n/pt-BR.json5

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10250,6 +10250,9 @@
1025010250
//"browse.search-form.placeholder": "Search the repository",
1025110251
"browse.search-form.placeholder": "Buscar no repositório",
1025210252

10253-
// "register-email.aria.label": "Enter your e-mail address",
10254-
"register-email.aria.label": "Digite seu e-mail",
10253+
// "register-page.registration.aria.label": "Enter your e-mail address",
10254+
"register-page.registration.aria.label": "Digite seu e-mail",
10255+
10256+
// "forgot-email.form.aria.label": "Enter your e-mail address",
10257+
"forgot-email.form.aria.label": "Digite seu e-mail",
1025510258
}

0 commit comments

Comments
 (0)