-
Notifications
You must be signed in to change notification settings - Fork 485
Open
Labels
Difficulty: HighEstimated at more than 16 hoursEstimated at more than 16 hourscomponent: submissiondependenciesPull requests that update a dependency filePull requests that update a dependency filehelp wantedNeeds a volunteer to claim to move forwardNeeds a volunteer to claim to move forwardhigh priorityimprovementnew feature
Description
Issue / context
During the Angular 15 upgrade, @Atmire-Kristof noticed conflicts between the newer versions of the following libraries:
ng-bootstrap
- v14 supports Angular 15 properly
@ng-dynamic-forms
- v16+ claims to support Angular 15, but
@ng-dynamic-forms/ui-ng-bootstrap
still requiresng-bootstrap
v11 as a peer dependency, which itself doesn't support Angular 15 - After "forcing" the upgrade, builds fail because of inconsistencies between the
ng-bootstrap
versions, so this is not a viable workaround
- v16+ claims to support Angular 15, but
Rather than do a half-upgrade we opted to leave both of these libraries as-is for now. This leads to peer dependency mismatch warnings, but everything remains functional.
Solution
It looks like development of @ng-dynamic-forms
has slowed down as of late, and this version mismatch is a bit of a red flag. Therefore, we should consider moving away from this library and use the default Angular forms instead for more stability.
This would involve a significant refactor of DSpace Angular submission.
References
Add references/links to any related issues or PRs. These may include:
tdonohue, bram-atmire, alanorth, artlowel and saschaszott
Metadata
Metadata
Assignees
Labels
Difficulty: HighEstimated at more than 16 hoursEstimated at more than 16 hourscomponent: submissiondependenciesPull requests that update a dependency filePull requests that update a dependency filehelp wantedNeeds a volunteer to claim to move forwardNeeds a volunteer to claim to move forwardhigh priorityimprovementnew feature
Type
Projects
Status
π To Do