DsDynamicFormControlContainerComponent: Implementing both DoCheck and OnChanges is not recommended

[saschaszott]

Problem Description

DsDynamicFormControlContainerComponent implements both DoCheck and OnChanges:

dspace-angular/src/app/shared/form/builder/ds-dynamic-form-ui/ds-dynamic-form-control-container.component.ts

Line 320 in 0649342

ngDoCheck() {

dspace-angular/src/app/shared/form/builder/ds-dynamic-form-ui/ds-dynamic-form-control-container.component.ts

Line 308 in 0649342

ngOnChanges(changes: SimpleChanges) {

Implementing both lifecycle hooks in a component triggers an ESLint warning: Implementing DoCheck and OnChanges in a class is not recommended.

OnChanges is triggered only when @Input() properties change, making it more efficient. DoCheck runs on every change detection cycle, which can lead to unnecessary performance overhead. Using both together can cause redundant checks and inefficiencies.