Skip to content

Edit-bitstream-page component is difficult to theme #4101

@AAwouters

Description

@AAwouters

The edit-bitstream-page component is very difficult to theme at the moment.
When an additional field has to be added to add additional metadata to the bitstream, nearly all methods have to be overridden.
In addition, due to the way the methods are structured there are some difficult-to-spot nested observable subscriptions.

For example:
The ngOnInit method creates multiple observables, and subscribes to them immediately to 'set the IIIF status'.
The setIiifStatus method then creates some more observables (some of which containing data that has been retrieved previously) and again subscribes to them in the same method to continue with 'setting the form'.
This chain of method calls continues with updateForm and updateFormatLayout.

The onSubmit method is another long method making use of multiple observables and an immediate subscription.

Metadata

Metadata

Assignees

Labels

affects: 7.xIssue impacts 7.x releasesaffects: 8.xIssue impacts 8.x releasesaffects: mainIssue impacts "main" (latest release).claimed: AtmireAtmire team is working on this issue & will contribute backimprovement

Type

Projects

Status

🏗 In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions