Skip to content

Downloads are broken in main branch #4122

@kshepherd

Description

@kshepherd

Describe the bug

No downloads (bitstream download page component) are working, since the merge of #4018 - there is no error displayed but the download attachment never proceeds.

The problem can be seen on https://sandbox.dspace.org with any download.

If you revert BitstreamDownloadPageComponent back to its state before the Matomo changes were merged, it begins to work again.

Given their close merge proximity and that they both modified the same file, I wonder if the conflict resolution / compatibility with the #3984 needs to be double checked.

To Reproduce

  1. In my case, I have not configured or done anything particular with Matomo config. I'm not sure what the official sandbox config looks like
  2. Try to download any item bitstream or process output file in DSpace main or https://sandbox.dspace.org

Expected behavior

The download works, whether or not there is an access badge, access token, or Matomo is configured

Notes

Looking through our spec tests, I can see it's really not easy to catch this sort of thing outside of full e2e testing?

Related work

I think this is caused by #4018

Metadata

Metadata

Type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions