Infinite loading spinner on opening a workflow item

[jlipka]

Describe the bug

Opening a workflow item for a review can result in an error that makes it look like DSpace is still loading data (infinite loading spinner appears), while an error is shown in the console log.

The bug is reproducible.

To Reproduce

1. Open the list of Workflow tasks and claim any item with the result the "EDIT"-Button (and others) appear
2. (Open your browser dev tools to watch at the browser console)
3. Reload the whole page of the Workflow tasks or open a new tab, https://demo.dspace.org/mydspace?configuration=workflow - (Its important to hard-reload the complete page - do not navigate previously on any other pages)
4. Now wait for - lets say - 10 seconds or any longer
5. Now click on the "EDIT"-Button of the previously claimed item
6. This error occurs: ERROR TypeError: can't access property "id", O.payload.collection is undefined

The error leads to this code line:

dspace-angular/src/app/submission/edit/submission-edit.component.ts

Line 161 in 9b72b1c

this.collectionId = (submissionObjectRD.payload.collection as Collection).id;

Expected behavior

I expect the edit form page to open, as it works when I click the EDIT button directly after performing a hard reload without waiting for some seconds.

The steps mentioned to reproduce the bug are just for visualisation purposes. I'm sure there are other click sequences that lead to the same error when using DSpace all day long.

Tested on https://demo.dspace.org/ (v9) and https://sandbox.dspace.org/ (v10) as well on our customized v8 instance.

Screenshot

Related work

#3697