Click on New user registration, then log in: no redirection to the homepage

[GraziaQuercia]

Describe the bug

If a user clicks on the "New user? Click here to register" button, a registration page is displayed. If the user logs in from that page, the system does not redirect to the homepage.

To Reproduce

Steps to reproduce the behavior:

1. Click on New user? Click here to register
2. Wait for the page to load
3. staying on the page, log in
4. Check that the displayed page is still the new user registration

DSpace.Repository.__.Home.2.mp4

Expected behavior

After logging in, the homepage should be displayed in any case

[tdonohue]

@GraziaQuercia : I believe this is because whenever you authenticate from a page in DSpace, you will be sent back to that same page after authentication. So, for example, if you browse to a specific Item, then login, you'll remain on that Item page. You re not sent back to the homepage after login.

In other words, no matter what page you are on, if you login, you will remain on that page.

I'm not sure this behavior is a bug. The intention is to ensure the user can login from any page, and not be redirected elsewhere.

[FrancescoMolinaro]

Hi @tdonohue ,

I agree that the current redirect behavior on login is correct and shouldn’t be changed. However, I’m not sure it makes sense to keep the /register route accessible to users who are already logged in.

We could consider improving the route guard in src/app/core/data/feature-authorization/feature-authorization-guard/site-register.guard.ts to check for this scenario. In that case, it would also be useful to define a clear redirect strategy. A couple of options that seem reasonable:

302 Found / 303 See Other: Redirect to the home page.

403 Forbidden: Explicitly block access if a logged-in user attempts to access the route.

It might be helpful to discuss this in our next community meeting to gather feedback and reach a consensus on the best approach.

What do you think?