ORCID Queue list is displaying publication items that are in workspace or workflow (not yet archived).

[pilasou]

Describe the bug

In a user ORCID synchronization page, once a relation is made beetween a person and a publication, the publication will appear in the user ORCID queue for synchronization no matter the status of the publication item (Workspace or Workflow).

To Reproduce

Steps to reproduce the behavior (for workspace item):

1. Connect to DSpace using ORCID credentials
2. In user account, clic on Profile and create user Researcher Profile (this will create a new Person Item page using the name and email address of the Eperson account),
3. Go to the new Person Item page and clic on Open ORCID setting page (button on the top right of the page) to access the ORCID synchronization page (see below)

4. In the ORCID Synchronization settings, in Publication reference, enable synchronization for All publications and clic on Update settings button

5. Start a new submissions and unsure to add the person as authors using the magnifyng glass button, result should look similar as below once added :

6. Also add a title and clic on Save for later button

7. Go back to user ORCID synchronization page,

8. At the bottom of the page, the ORCID queue list will display the unfinished submission

Expected behavior

Workflow or workspace item must not be displayed in the ORCID queue list for synchronization.

[floriangantner]

Hi @pilasou ,
i currently cannot reproduce the behaviour due to technical limitations on my setup, but for me and my experience with the Orcid Integration in DSpace-Cris 7.x in the past this seems to be some error on the spring backend.

There are two ways where the orcid queue is calculated or entries are added.
On the one side there is the OrcidQueueConsumer
https://github.com/DSpace/DSpace/blob/e64b226de5655e93d4a010c8498ab45969ab4d87/dspace-api/src/main/java/org/dspace/orcid/consumer/OrcidQueueConsumer.java#L117
This consumer considers not archived items which should not added to the itemsToConsume Hashmap. But somehow the workspace and workflow items seems to pass through here, so one approach could be setting some breakpoint there. Could you give it a try? Perhaps the consumer is also called multiple times when both the item with type Publication and the item with type Person are saved.

On the other side there is the OrcidQueueServiceImpl which recalculates the queue, when the orcid sync settings for the entities have changed. It uses some mechanism different than the Consumer to determine the items: https://github.com/DSpace/DSpace/blob/e64b226de5655e93d4a010c8498ab45969ab4d87/dspace-api/src/main/java/org/dspace/orcid/service/impl/OrcidQueueServiceImpl.java#L216 . Given your base case as described before, when you disable the publication sync and re-set it to "All publications", does the workspace/workflow item still appear in the queue?

[pilasou]

Thanks @floriangantner We try the sync settings reset as you mentionned. It worked as you describe and the majority of the item were updated. Some errors remains though (I have asked the tech group form help: https://groups.google.com/g/dspace-tech/c/TnNbEjbEZvg/m/0XBNVt-pAwAJ). However, the major problem are the workspace items (items that were begun but never completed by the user). They must not be part of the ORCID synch. They are sent to the user ORCID profil usually with bad metadata. And they have the potential to stay there forever as the user may never complet the deposit or delete it.

[pilasou]

Hi @floriangantner @tdonohue, ok so it seems that there may be a quick fix on this one by adding "item.isArchived()" in the file OrcidQueueServiceImpl.java. The change would be on lign 223-230 :

private List findAllEntitiesLinkableWith(Context context, Item profile, String entityType) {

    return findRelationshipsByItem(context, profile).stream()
        .map(relationship -> getRelatedItem(relationship, profile))
        .filter(item -> **item.isArchived() &&** entityType.equals(itemService.getEntityTypeLabel(item)))
        .collect(Collectors.toList());

}