Skip to content

missing implementation in RoleService: hard-coded return values in isController / isAdmin  #3331

@saschaszott

Description

@saschaszott

Describe the bug

RoleService provides methods to check whether a given user is submitter / controller / admin. The implementations of both methods isController and isAdmin are missing (TODO comment was added 5 years ago by @atarix83):

return observableOf(true);

return observableOf(false);

Consequently, every logged-in user has the controller "role" and the dropdown field in "MyDSpace" shows inappropriate option values. The screenshot below shows the options available to the demo user dspacedemo+submit@gmail.com (which has only the submitter role):

image

Metadata

Metadata

Assignees

Type

No type

Projects

Status

🏗 In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions