129629: Add models to provide-core.ts and remove duplicates#4115
Merged
tdonohue merged 2 commits intoDSpace:mainfrom Jul 30, 2025
Merged
Conversation
This doesn't seem to be used anywhere and was throwing some errors.
1bbe575 to
2eb09b3
Compare
tdonohue
approved these changes
Jul 30, 2025
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @AbhinavS96 ! I tested the various components that were added and found no change in behavior. Everything looks good.
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Feb 16, 2026
DSC-2745 Approved-by: Giuseppe Digilio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Added in all the model classes mentioned in the issue. Removed some duplicates as well. SubmissionCoarNotifyWorkspaceitemModel removed from the code base. This doesn't seem to be used and is throwing errors when added to the models.
Instructions for Reviewers
List of changes in this PR:
List
modelsupdated inprovide-core.tsSubmissionCoarNotifyWorkspaceitemModel removed
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.