api: fix route order - it matters

Author: DSpeichert

api/server.go

@@ -64,13 +64,19 @@ func NewServer(store *store.Store, authorization string) (server *Server, err er
 		})
 	})
 
-	// GET /api/manifests
-	r.HandleFunc("/api/manifests", func(w http.ResponseWriter, r *http.Request) {
+	// GET /api/manifests/{id}
+	r.HandleFunc("/api/manifests/{id}", func(w http.ResponseWriter, r *http.Request) {
 		if authorization != r.Header.Get("Authorization") {
 			http.Error(w, "Forbidden", http.StatusForbidden)
 			return
 		}
 
+		vars := mux.Vars(r)
+		m := store.Find(vars["id"])
+		if m == nil {
+			http.Error(w, "not found", http.StatusNotFound)
+			return
+		}
 		var b []byte
 		if strings.Contains(r.Header.Get("Accept"), "application/json") {
 			w.Header().Set("Content-Type", "applications/json")
@@ -83,19 +89,13 @@ func NewServer(store *store.Store, authorization string) (server *Server, err er
 		w.Write(b)
 	}).Methods("GET")
 
-	// GET /api/manifests/{id}
-	r.HandleFunc("/api/manifests/{id}", func(w http.ResponseWriter, r *http.Request) {
+	// GET /api/manifests
+	r.HandleFunc("/api/manifests", func(w http.ResponseWriter, r *http.Request) {
 		if authorization != r.Header.Get("Authorization") {
 			http.Error(w, "Forbidden", http.StatusForbidden)
 			return
 		}
 
-		vars := mux.Vars(r)
-		m := store.Find(vars["id"])
-		if m == nil {
-			http.Error(w, "not found", http.StatusNotFound)
-			return
-		}
 		var b []byte
 		if strings.Contains(r.Header.Get("Accept"), "application/json") {
 			w.Header().Set("Content-Type", "applications/json")