Skip to content

Commit 009f513

Browse files
committed
[opt][restapi] remove unUse variable
1 parent 0e383d0 commit 009f513

File tree

5 files changed

+10
-46
lines changed

5 files changed

+10
-46
lines changed

flinkx-restapi/flinkx-restapi-core/src/main/java/com/dtstack/flinkx/restapi/common/ConstantVarible.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@
33
public class ConstantVarible<T> implements Paramitem {
44
private final T object;
55
private final String name;
6-
// private ParamDefinition paramDefinition;
76

87
public ConstantVarible(T object, String name) {
98
this.object = object;
109
this.name = name;
11-
// this.paramDefinition = paramDefinition;
1210
}
1311

1412
@Override
@@ -21,8 +19,4 @@ public String getName() {
2119
return name;
2220
}
2321

24-
// @Override
25-
// public ParamDefinition getParamDefinition() {
26-
// return paramDefinition;
27-
// }
2822
}

flinkx-restapi/flinkx-restapi-core/src/main/java/com/dtstack/flinkx/restapi/common/UuidVarible.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ public class UuidVarible implements Paramitem<String> {
88
public UuidVarible() {
99
}
1010

11-
// public UuidVarible(ParamDefinition paramDefinition) {
12-
// this.paramDefinition = paramDefinition;
13-
// }
14-
1511
@Override
1612
public String getValue(RestContext restContext) {
1713
return UUID.randomUUID().toString();
@@ -22,10 +18,4 @@ public String getName() {
2218
return "currentTime";
2319
}
2420

25-
// @Override
26-
// public ParamDefinition getParamDefinition() {
27-
// return paramDefinition;
28-
// }
29-
30-
3121
}

flinkx-restapi/flinkx-restapi-reader/src/main/java/com/dtstack/flinkx/restapi/inputformat/HttpClient.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ public class HttpClient {
5656
private final long intervalTime;
5757
private BlockingQueue<Row> queue;
5858
private RestContext restContext;
59-
private AtomicInteger atomicInteger = new AtomicInteger(0);
6059
private static final String THREAD_NAME = "restApiReader-thread";
6160
private List<MetaColumn> metaColumns;
6261
private List<DataHandler> handlers;
@@ -96,7 +95,6 @@ public Row takeEvent() {
9695
}
9796

9897
public void execute() {
99-
int i = atomicInteger.incrementAndGet();
10098
httprequestApi.Httprequest build = restContext.build();
10199
doExecute(build, 2);
102100
restContext.updateValue();

flinkx-restapi/flinkx-restapi-reader/src/main/java/com/dtstack/flinkx/restapi/inputformat/RestapiInputFormat.java

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,24 +38,17 @@
3838
*/
3939
public class RestapiInputFormat extends BaseRichInputFormat {
4040

41-
protected String url;
42-
43-
protected String method;
44-
45-
4641
protected HttpClient myHttpClient;
4742

4843
protected RestContext restContext;
4944

50-
protected Map<String, Object> header;
51-
5245
protected Long intervalTime;
5346

54-
private HttpRestConfig httpRestConfig;
47+
protected HttpRestConfig httpRestConfig;
5548

56-
private List<MetaColumn> metaColumns ;
49+
protected List<MetaColumn> metaColumns ;
5750

58-
private List<DataHandler> handlers;
51+
protected List<DataHandler> handlers;
5952

6053
@Override
6154
public void openInputFormat() throws IOException {

flinkx-restapi/flinkx-restapi-reader/src/main/java/com/dtstack/flinkx/restapi/inputformat/RestapiInputFormatBuilder.java

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.dtstack.flinkx.reader.MetaColumn;
2222
import com.dtstack.flinkx.restapi.common.handler.DataHandler;
2323
import com.dtstack.flinkx.restapi.reader.HttpRestConfig;
24+
import org.apache.commons.lang3.StringUtils;
2425

2526
import java.util.List;
2627
import java.util.Map;
@@ -37,18 +38,6 @@ public RestapiInputFormatBuilder() {
3738
super.format = format = new RestapiInputFormat();
3839
}
3940

40-
public void setUrl(String url) {
41-
this.format.url = url;
42-
}
43-
44-
public void setHeader(Map<String, Object> header) {
45-
this.format.header = header;
46-
}
47-
48-
public void setMethod(String method) {
49-
this.format.method = method;
50-
}
51-
5241
public void setHttpRestConfig(HttpRestConfig httpRestConfig) {
5342
this.format.setHttpRestConfig(httpRestConfig);
5443
}
@@ -67,11 +56,11 @@ public void setHandlers(List<DataHandler> handlers) {
6756

6857
@Override
6958
protected void checkFormat() {
70-
// if(format.url.isEmpty()){
71-
// throw new IllegalArgumentException("缺少url");
72-
// }
73-
// if (format.method.isEmpty()) {
74-
// throw new IllegalArgumentException("缺少method");
75-
// }
59+
if(StringUtils.isBlank(format.httpRestConfig.getUrl())){
60+
throw new IllegalArgumentException("缺少url");
61+
}
62+
if (StringUtils.isBlank(format.httpRestConfig.getType())) {
63+
throw new IllegalArgumentException("缺少method");
64+
}
7665
}
7766
}

0 commit comments

Comments
 (0)