Skip to content

Commit d61995f

Browse files
committed
Sync issue forms and PR template
1 parent 0b88795 commit d61995f

File tree

1 file changed

+38
-0
lines changed

1 file changed

+38
-0
lines changed

.github/pull_request_template.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# Description
2+
3+
_If full decription and testing details are included on a parent issue, please link to that here._
4+
See issue # for details
5+
6+
_Otherwise, please include a summary of the change and which issue is fixed (if any).
7+
Include relevant motivation and context, including a target environment and dunedaq version if known.
8+
Also list any dependencies that are required for this change._
9+
Addresses issue #
10+
11+
_Please also include instructions for how a reviewer can test your changes._
12+
13+
14+
## Type of change
15+
16+
- [ ] Documentation (non-breaking change that adds or improves the documentation)
17+
- [ ] New feature or enhancement (non-breaking change which adds functionality)
18+
- [ ] Optimization (non-breaking change that improves code/performance)
19+
- [ ] Bug fix (non-breaking change which fixes an issue)
20+
- [ ] Breaking change (whatever its nature)
21+
22+
## Testing checklist
23+
24+
- [ ] Unit tests pass (e.g. `dbt-build --unittest`)
25+
- [ ] Minimal system quicktest passes (`pytest -s minimal_system_quick_test.py`)
26+
- [ ] Full set of integration tests pass (`daqsystemtest_integtest_bundle.sh`)
27+
- [ ] Python tests pass if applicable (e.g. `python -m pytest`)
28+
- [ ] Pre-commit hooks run successfully if applicable (e.g. `pre-commit run --all-files`)
29+
30+
_Comments here on the testing_
31+
32+
## Further checks
33+
34+
- [ ] Code is commented where needed, particularly in hard-to-understand areas
35+
- [ ] Code style is correct (`dbt-build --lint`, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
36+
- [ ] If applicable, new tests have been added or an issue has been opened to tackle that in the future.
37+
(Indicate issue here: # (issue))
38+

0 commit comments

Comments
 (0)