[Medium/Large Impact Change]: Generalisation of command line parameters for applications

[mroda88]

Description

The current configuration of the Connectivity service is a bit clunky as it require a double definition of the port of the connectivity service. Specifically:

• All elements in the DAQ get their port from the connectivity_service relationship of the session (link ). Internally this objects contains a Service that specifies the port.
• For a local configuration, an infrastructure application is defined that executes a command to spawn a ConnectionService instance via gunicorn. The catch is that the command is hardcoded and therefore, in order to make the port dynamic, an environmental variable is used to define the port in the command, see daqsystemtest.

This duplication is hard to maintain.

We should generalise the access to the command line parameter with a virtual function. The function specification of the ConnectionService should return the right command and take the port from the service that it contains already and it should not require the definition of an additional env variable.

Related issues and PRs

None

Impact radius

Medium

Impact on developers and users

This is a small change in the API of confmodel::Application. It will have impacts on drunc and maybe in appmodel.
EHN1daqconfigs should be affected. Only daqsystemtest will need to be updated to make the configuration easier

Useful coordination

No important coordination between WGs will be necessary, this is CCM internal.

Testing suggestions and/or changes needed in testing

Integration tests are already validating this process.

Anything else?

No response

[bieryAtFnal]

In the spirit of helping to make connectivity service configuration easier to understand, I believe that the CONNECTION_SERVER environmental variable is no longer used in our code, but it still appears in some of our configurations, for example here.

Recently, I removed the definition of this env var from the daqsystemtest example configuration, and I wonder if it should also be removed from other configs, e.g. ehn1-daqconfigs...

[mroda88]

Thanks, I made an issue on there so Michal can take care of that at his own time