Merge pull request #11 from DUNE-DAQ/kbiery/reduce_compiler_warnings

bieryAtFnal · web-flow · commit 65d89ce91ac5 · 2025-07-30T14:23:02.000-05:00
Made a few minor changes in CRTBernReaderModule.cpp and CRTGrenobleRe…
diff --git a/plugins/CRTBernReaderModule.cpp b/plugins/CRTBernReaderModule.cpp
@@ -57,7 +57,7 @@ constexpr uint64_t source_id = 1002;
 void
 fake_sequence_id(uint64_t& seq_id)
 {
-  seq_id = seq_id == max_seq_id ? 0 : ++seq_id;
+  seq_id = (seq_id == max_seq_id ? 0 : seq_id+1);
 }
 
 /**
@@ -163,7 +163,7 @@ CRTBernReaderModule::init(const std::shared_ptr<appfwk::ConfigurationManager> mf
 }
 
 void
-CRTBernReaderModule::do_conf(const nlohmann::json& obj)
+CRTBernReaderModule::do_conf(const nlohmann::json& /*obj*/)
 {
   // Configure HW interface?
   if (!m_run_marker.load()) {
diff --git a/plugins/CRTGrenobleReaderModule.cpp b/plugins/CRTGrenobleReaderModule.cpp
@@ -57,7 +57,7 @@ constexpr uint64_t source_id = 1001;
 void
 fake_sequence_id(uint64_t& seq_id)
 {
-  seq_id = seq_id == max_seq_id ? 0 : ++seq_id;
+  seq_id = (seq_id == max_seq_id ? 0 : seq_id+1);
 }
 
 /**
@@ -163,7 +163,7 @@ CRTGrenobleReaderModule::init(const std::shared_ptr<appfwk::ConfigurationManager
 }
 
 void
-CRTGrenobleReaderModule::do_conf(const nlohmann::json& obj)
+CRTGrenobleReaderModule::do_conf(const nlohmann::json& /*obj*/)
 {
   // Configure HW interface?
   if (!m_run_marker.load()) {

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ constexpr uint64_t source_id = 1002;`
`57`	`57`	`void`
`58`	`58`	`fake_sequence_id(uint64_t& seq_id)`
`59`	`59`	`{`
`60`		`- seq_id = seq_id == max_seq_id ? 0 : ++seq_id;`
	`60`	`+ seq_id = (seq_id == max_seq_id ? 0 : seq_id+1);`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`/**`
`@@ -163,7 +163,7 @@ CRTBernReaderModule::init(const std::shared_ptr<appfwk::ConfigurationManager> mf`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`void`
`166`		`-CRTBernReaderModule::do_conf(const nlohmann::json& obj)`
	`166`	`+CRTBernReaderModule::do_conf(const nlohmann::json& /obj/)`
`167`	`167`	`{`
`168`	`168`	`// Configure HW interface?`
`169`	`169`	`if (!m_run_marker.load()) {`