Skip to content

Confusing TP Count Member Variable Names #265

@aeoranday

Description

@aeoranday

There are 3 member variables related to TP counts: m_tpg_hits_count, m_new_hits, and m_new_tps. At first glance, they all seem to mean the same thing.

  • m_new_hits is unused by WIBEthFrameProcessor and TDEEthFrameProcessor. It is used by DAPHNEFrameProcessor.
  • m_tpg_hits_count is used by the TPC frame processors, but not used by the PDS frame processor.
  • m_new_tps is used by all 3 frame processors.

Of m_new_tps and m_new_hits/m_tpg_hits_count, the values assigned to the variables are the same (thankfully), but that makes these variables redundant. This should become a single variable that is consistent between all three.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions