-
Notifications
You must be signed in to change notification settings - Fork 3
Labels
enhancementNew feature or requestNew feature or request
Description
Description
The two TPC data formats, WIBEthFrame and TDEEthFrame, are processed using their respective frame processors. However, the only difference between the two processors is the data type. Instead, it will be more easily maintained if they are specializations from a generic TPCEthFrameProcessor class.
At the same time, various code structure problems have been identified in the WIBEthFrameProcessor and TDEEthFrameProcessor classes:
- Confusing TP Count Member Variable Names #265,
- Bloated
conffunction, - Specialize Frame Processors
scrapMethod #270, - Replace for-loops that assume only 3 planes numbered 0, 1, 2.
A feature that may also be added:
- Use Frame Processor Specific Channel-Plane Map #281 (mini channel-to-plane map)
Task List
- Make the generic
TPCEthFrameProcessorclass. - Clean member variables.
- Separate
confinto sub-functions. - Add
scrapspecialty. - Add the mini channel-to-plane map.
- Replace for-loops based on plane number assumptions.
- Test functionality on integration tests. (Must include TPG as part of this.)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request