Skip to content

[Feature]: Build Option To Enable/Disable TPG State Monitoring #39

@aeoranday

Description

@aeoranday

Description

The functionality of TPG's internal state monitor should become a build option instead of a configuration enable/disable.

Potential impact radius

Small/Isolated

Reason for change

It was noticed during performance testing that the logic for the internal state monitoring was a non-negligible cost to CPU usage while the monitoring was disabled. Shifting the functionality into a build option better preserves the performance requirement for TPG.

Suggested implementations

Both tpglibs and fdreadoutlibs should receive this build option change, where:

  • tpglibs toggles whether the functionality of internal state monitoring is present or not,
  • fdreadoutlibs continues to collect and publish the results when enabled and configured and emits a warning when disabled and configured.

Testing suggestions

Testing may be done in local test sessions to confirm the warning is present and that the monitored states are not being written. A test for performance impact must be done using a high TP rate and likely requires an EHN1 detector.

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions