Skip to content

Commit 8750d43

Browse files
author
Gianfranco Ingratta
committed
address Jeremy's comments
1 parent dc95ead commit 8750d43

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

duneanaobj/StandardRecord/SRRecoParticle.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ namespace caf
2323
public:
2424
static constexpr int kPdgHadronicBlob = 2000000002; ///< Special PDG code used for a "hadronic blob" (usu. calorimetrically reconstructed), borrowed from GENIE
2525

26-
unsigned int uid = 0; ///< Unique identifier for the SRTrack/SRShower (if any) associated to this SRRecoParticle
27-
2826
bool primary = false; ///< Is this reco particle a "primary" one (i.e. emanates directly from the reconstructed vertex)?
2927

3028
int pdg = 0; ///< PDG code inferred for this particle.

duneanaobj/StandardRecord/SRShower.h

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,23 +19,19 @@ namespace caf
1919
// less typing further below
2020
static constexpr float NaN = std::numeric_limits<float>::signaling_NaN();
2121

22-
unsigned int uid = 0; ///< Unique identifier to associate this SRShower with its SRRecoParticle object
23-
2422
SRVector3D start; ///< Shower 3D start point [cm]
25-
SRVector3D end; ///< Shower 3D end point [cm]
26-
SRVector3D direction; ///< Shower direction [cm]
23+
SRVector3D direction; ///< Shower direction (unit vector).
2724

28-
double time = NaN; ///< Time of shower formation [ns]
25+
double time = NaN; ///< Time of shower formation [ns]
2926

3027
float Evis = -999.; ///< Visible energy in voxels corresponding to this shower
3128

3229
float qual = NaN; ///< Reco-specific quality metric (for istance trackScore value)
3330

34-
float len_gcm2 = NaN; ///< Shower length in g/cm2
35-
float len_cm = NaN; ///< Shower length in centimeter (actual physical distance)
31+
float len_cm = NaN; ///< Shower length [cm]. The definition is reco-dependent; consult the documentation of the specific reconstruction algorithm (e.g. Pandora, SPINE) for its exact meaning before use.
3632

37-
float dEdx; ///< dE/dx value at the shower start
38-
float conversionGap; ///< Spatial distance between the photon creation and its conversion into e+e- pair [cm]
33+
float initial_dEdx; ///< dE/dx value at the shower start
34+
float conversionGap; ///< Spatial distance between the photon creation and its conversion into e+e- pair [cm]
3935

4036
std::vector<TrueParticleID> truth; ///< Associated SRTrueParticle(s), if relevant (use SRTruthBranch::Particle() with these IDs to grab them)
4137
std::vector<float> truthOverlap; ///< Fractional overlap between this shower and true particle

duneanaobj/StandardRecord/SRTrack.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ namespace caf
1919
// less typing further below
2020
static constexpr float NaN = std::numeric_limits<float>::signaling_NaN();
2121

22-
unsigned int uid = 0; ///< Unique identifier to associate this SRTrack with its SRRecoParticle object
23-
2422
SRVector3D start; ///< Track 3D start point [cm]
2523
SRVector3D end; ///< Track 3D end point [cm]
2624
SRVector3D dir; ///< Unit vector representing estimate of track direction *taken from start point*

0 commit comments

Comments
 (0)