Skip to content

Commit 6858c1f

Browse files
authored
libudev: several trivial cleanups (systemd#37106)
2 parents b1236ce + 9ee08c8 commit 6858c1f

File tree

10 files changed

+154
-150
lines changed

10 files changed

+154
-150
lines changed

src/libudev/libudev-device-internal.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66

77
struct udev_device;
88

9-
struct udev_device *udev_device_new(struct udev *udev, sd_device *device);
10-
sd_device *udev_device_get_sd_device(struct udev_device *udev_device);
9+
struct udev_device* udev_device_new(struct udev *udev, sd_device *device);
10+
sd_device* udev_device_get_sd_device(struct udev_device *udev_device);

src/libudev/libudev-device.c

Lines changed: 32 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ _public_ dev_t udev_device_get_devnum(struct udev_device *udev_device) {
120120
*
121121
* Returns: the driver name string, or #NULL if there is no driver attached.
122122
**/
123-
_public_ const char *udev_device_get_driver(struct udev_device *udev_device) {
123+
_public_ const char* udev_device_get_driver(struct udev_device *udev_device) {
124124
const char *driver;
125125
int r;
126126

@@ -141,7 +141,7 @@ _public_ const char *udev_device_get_driver(struct udev_device *udev_device) {
141141
*
142142
* Returns: the devtype name of the udev device, or #NULL if it cannot be determined
143143
**/
144-
_public_ const char *udev_device_get_devtype(struct udev_device *udev_device) {
144+
_public_ const char* udev_device_get_devtype(struct udev_device *udev_device) {
145145
const char *devtype;
146146
int r;
147147

@@ -165,7 +165,7 @@ _public_ const char *udev_device_get_devtype(struct udev_device *udev_device) {
165165
*
166166
* Returns: the subsystem name of the udev device, or #NULL if it cannot be determined
167167
**/
168-
_public_ const char *udev_device_get_subsystem(struct udev_device *udev_device) {
168+
_public_ const char* udev_device_get_subsystem(struct udev_device *udev_device) {
169169
const char *subsystem;
170170
int r;
171171

@@ -187,7 +187,7 @@ _public_ const char *udev_device_get_subsystem(struct udev_device *udev_device)
187187
*
188188
* Returns: the property string, or #NULL if there is no such property.
189189
**/
190-
_public_ const char *udev_device_get_property_value(struct udev_device *udev_device, const char *key) {
190+
_public_ const char* udev_device_get_property_value(struct udev_device *udev_device, const char *key) {
191191
const char *value;
192192
int r;
193193

@@ -200,7 +200,7 @@ _public_ const char *udev_device_get_property_value(struct udev_device *udev_dev
200200
return value;
201201
}
202202

203-
struct udev_device *udev_device_new(struct udev *udev, sd_device *device) {
203+
struct udev_device* udev_device_new(struct udev *udev, sd_device *device) {
204204
_cleanup_(udev_list_freep) struct udev_list *properties = NULL, *all_tags = NULL, *current_tags = NULL, *sysattrs = NULL, *devlinks = NULL;
205205
struct udev_device *udev_device;
206206

@@ -254,7 +254,7 @@ struct udev_device *udev_device_new(struct udev *udev, sd_device *device) {
254254
*
255255
* Returns: a new udev device, or #NULL, if it does not exist
256256
**/
257-
_public_ struct udev_device *udev_device_new_from_syspath(struct udev *udev, const char *syspath) {
257+
_public_ struct udev_device* udev_device_new_from_syspath(struct udev *udev, const char *syspath) {
258258
_cleanup_(sd_device_unrefp) sd_device *device = NULL;
259259
int r;
260260

@@ -281,7 +281,7 @@ _public_ struct udev_device *udev_device_new_from_syspath(struct udev *udev, con
281281
*
282282
* Returns: a new udev device, or #NULL, if it does not exist
283283
**/
284-
_public_ struct udev_device *udev_device_new_from_devnum(struct udev *udev, char type, dev_t devnum) {
284+
_public_ struct udev_device* udev_device_new_from_devnum(struct udev *udev, char type, dev_t devnum) {
285285
_cleanup_(sd_device_unrefp) sd_device *device = NULL;
286286
int r;
287287

@@ -310,7 +310,7 @@ _public_ struct udev_device *udev_device_new_from_devnum(struct udev *udev, char
310310
*
311311
* Returns: a new udev device, or #NULL, if it does not exist
312312
**/
313-
_public_ struct udev_device *udev_device_new_from_device_id(struct udev *udev, const char *id) {
313+
_public_ struct udev_device* udev_device_new_from_device_id(struct udev *udev, const char *id) {
314314
_cleanup_(sd_device_unrefp) sd_device *device = NULL;
315315
int r;
316316

@@ -336,7 +336,7 @@ _public_ struct udev_device *udev_device_new_from_device_id(struct udev *udev, c
336336
*
337337
* Returns: a new udev device, or #NULL, if it does not exist
338338
**/
339-
_public_ struct udev_device *udev_device_new_from_subsystem_sysname(struct udev *udev, const char *subsystem, const char *sysname) {
339+
_public_ struct udev_device* udev_device_new_from_subsystem_sysname(struct udev *udev, const char *subsystem, const char *sysname) {
340340
_cleanup_(sd_device_unrefp) sd_device *device = NULL;
341341
int r;
342342

@@ -361,7 +361,7 @@ _public_ struct udev_device *udev_device_new_from_subsystem_sysname(struct udev
361361
*
362362
* Returns: a new udev device, or #NULL, if it does not exist
363363
**/
364-
_public_ struct udev_device *udev_device_new_from_environment(struct udev *udev) {
364+
_public_ struct udev_device* udev_device_new_from_environment(struct udev *udev) {
365365
_cleanup_(sd_device_unrefp) sd_device *device = NULL;
366366
int r;
367367

@@ -372,7 +372,7 @@ _public_ struct udev_device *udev_device_new_from_environment(struct udev *udev)
372372
return udev_device_new(udev, device);
373373
}
374374

375-
static struct udev_device *device_new_from_parent(struct udev_device *child) {
375+
static struct udev_device* device_new_from_parent(struct udev_device *child) {
376376
sd_device *parent;
377377
int r;
378378

@@ -403,7 +403,7 @@ static struct udev_device *device_new_from_parent(struct udev_device *child) {
403403
*
404404
* Returns: a new udev device, or #NULL, if it no parent exist.
405405
**/
406-
_public_ struct udev_device *udev_device_get_parent(struct udev_device *udev_device) {
406+
_public_ struct udev_device* udev_device_get_parent(struct udev_device *udev_device) {
407407
assert_return_errno(udev_device, NULL, EINVAL);
408408

409409
if (!udev_device->parent_set) {
@@ -436,7 +436,11 @@ _public_ struct udev_device *udev_device_get_parent(struct udev_device *udev_dev
436436
*
437437
* Returns: a new udev device, or #NULL if no matching parent exists.
438438
**/
439-
_public_ struct udev_device *udev_device_get_parent_with_subsystem_devtype(struct udev_device *udev_device, const char *subsystem, const char *devtype) {
439+
_public_ struct udev_device* udev_device_get_parent_with_subsystem_devtype(
440+
struct udev_device *udev_device,
441+
const char *subsystem,
442+
const char *devtype) {
443+
440444
sd_device *parent;
441445
int r;
442446

@@ -467,13 +471,13 @@ _public_ struct udev_device *udev_device_get_parent_with_subsystem_devtype(struc
467471
*
468472
* Returns: the udev library context
469473
**/
470-
_public_ struct udev *udev_device_get_udev(struct udev_device *udev_device) {
474+
_public_ struct udev* udev_device_get_udev(struct udev_device *udev_device) {
471475
assert_return_errno(udev_device, NULL, EINVAL);
472476

473477
return udev_device->udev;
474478
}
475479

476-
static struct udev_device *udev_device_free(struct udev_device *udev_device) {
480+
static struct udev_device* udev_device_free(struct udev_device *udev_device) {
477481
assert(udev_device);
478482

479483
sd_device_unref(udev_device->device);
@@ -517,7 +521,7 @@ DEFINE_PUBLIC_TRIVIAL_REF_UNREF_FUNC(struct udev_device, udev_device, udev_devic
517521
*
518522
* Returns: the devpath of the udev device
519523
**/
520-
_public_ const char *udev_device_get_devpath(struct udev_device *udev_device) {
524+
_public_ const char* udev_device_get_devpath(struct udev_device *udev_device) {
521525
const char *devpath;
522526
int r;
523527

@@ -539,7 +543,7 @@ _public_ const char *udev_device_get_devpath(struct udev_device *udev_device) {
539543
*
540544
* Returns: the sys path of the udev device
541545
**/
542-
_public_ const char *udev_device_get_syspath(struct udev_device *udev_device) {
546+
_public_ const char* udev_device_get_syspath(struct udev_device *udev_device) {
543547
const char *syspath;
544548
int r;
545549

@@ -560,7 +564,7 @@ _public_ const char *udev_device_get_syspath(struct udev_device *udev_device) {
560564
*
561565
* Returns: the name string of the device
562566
**/
563-
_public_ const char *udev_device_get_sysname(struct udev_device *udev_device) {
567+
_public_ const char* udev_device_get_sysname(struct udev_device *udev_device) {
564568
const char *sysname;
565569
int r;
566570

@@ -581,7 +585,7 @@ _public_ const char *udev_device_get_sysname(struct udev_device *udev_device) {
581585
*
582586
* Returns: the trailing number string of the device name
583587
**/
584-
_public_ const char *udev_device_get_sysnum(struct udev_device *udev_device) {
588+
_public_ const char* udev_device_get_sysnum(struct udev_device *udev_device) {
585589
const char *sysnum;
586590
int r;
587591

@@ -605,7 +609,7 @@ _public_ const char *udev_device_get_sysnum(struct udev_device *udev_device) {
605609
*
606610
* Returns: the device node file name of the udev device, or #NULL if no device node exists
607611
**/
608-
_public_ const char *udev_device_get_devnode(struct udev_device *udev_device) {
612+
_public_ const char* udev_device_get_devnode(struct udev_device *udev_device) {
609613
const char *devnode;
610614
int r;
611615

@@ -631,7 +635,7 @@ _public_ const char *udev_device_get_devnode(struct udev_device *udev_device) {
631635
*
632636
* Returns: the first entry of the device node link list
633637
**/
634-
_public_ struct udev_list_entry *udev_device_get_devlinks_list_entry(struct udev_device *udev_device) {
638+
_public_ struct udev_list_entry* udev_device_get_devlinks_list_entry(struct udev_device *udev_device) {
635639
assert_return_errno(udev_device, NULL, EINVAL);
636640

637641
if (device_get_devlinks_generation(udev_device->device) != udev_device->devlinks_generation ||
@@ -661,7 +665,7 @@ _public_ struct udev_list_entry *udev_device_get_devlinks_list_entry(struct udev
661665
*
662666
* Returns: the first entry of the property list
663667
**/
664-
_public_ struct udev_list_entry *udev_device_get_properties_list_entry(struct udev_device *udev_device) {
668+
_public_ struct udev_list_entry* udev_device_get_properties_list_entry(struct udev_device *udev_device) {
665669
assert_return_errno(udev_device, NULL, EINVAL);
666670

667671
if (device_get_properties_generation(udev_device->device) != udev_device->properties_generation ||
@@ -689,7 +693,7 @@ _public_ struct udev_list_entry *udev_device_get_properties_list_entry(struct ud
689693
*
690694
* Returns: the kernel action value, or #NULL if there is no action value available.
691695
**/
692-
_public_ const char *udev_device_get_action(struct udev_device *udev_device) {
696+
_public_ const char* udev_device_get_action(struct udev_device *udev_device) {
693697
sd_device_action_t action;
694698

695699
assert_return_errno(udev_device, NULL, EINVAL);
@@ -735,7 +739,7 @@ _public_ unsigned long long int udev_device_get_usec_since_initialized(struct ud
735739
*
736740
* Returns: the content of a sys attribute file, or #NULL if there is no sys attribute value.
737741
**/
738-
_public_ const char *udev_device_get_sysattr_value(struct udev_device *udev_device, const char *sysattr) {
742+
_public_ const char* udev_device_get_sysattr_value(struct udev_device *udev_device, const char *sysattr) {
739743
const char *value;
740744
int r;
741745

@@ -780,7 +784,7 @@ _public_ int udev_device_set_sysattr_value(struct udev_device *udev_device, cons
780784
*
781785
* Returns: the first entry of the property list
782786
**/
783-
_public_ struct udev_list_entry *udev_device_get_sysattr_list_entry(struct udev_device *udev_device) {
787+
_public_ struct udev_list_entry* udev_device_get_sysattr_list_entry(struct udev_device *udev_device) {
784788
assert_return_errno(udev_device, NULL, EINVAL);
785789

786790
if (!udev_device->sysattrs_read) {
@@ -832,7 +836,7 @@ _public_ int udev_device_get_is_initialized(struct udev_device *udev_device) {
832836
*
833837
* Returns: the first entry of the tag list
834838
**/
835-
_public_ struct udev_list_entry *udev_device_get_tags_list_entry(struct udev_device *udev_device) {
839+
_public_ struct udev_list_entry* udev_device_get_tags_list_entry(struct udev_device *udev_device) {
836840
assert_return_errno(udev_device, NULL, EINVAL);
837841

838842
if (device_get_tags_generation(udev_device->device) != udev_device->all_tags_generation ||
@@ -850,7 +854,7 @@ _public_ struct udev_list_entry *udev_device_get_tags_list_entry(struct udev_dev
850854
return udev_list_get_entry(udev_device->all_tags);
851855
}
852856

853-
_public_ struct udev_list_entry *udev_device_get_current_tags_list_entry(struct udev_device *udev_device) {
857+
_public_ struct udev_list_entry* udev_device_get_current_tags_list_entry(struct udev_device *udev_device) {
854858
assert_return_errno(udev_device, NULL, EINVAL);
855859

856860
if (device_get_tags_generation(udev_device->device) != udev_device->current_tags_generation ||
@@ -889,7 +893,7 @@ _public_ int udev_device_has_current_tag(struct udev_device *udev_device, const
889893
return sd_device_has_current_tag(udev_device->device, tag) > 0;
890894
}
891895

892-
sd_device *udev_device_get_sd_device(struct udev_device *udev_device) {
896+
sd_device* udev_device_get_sd_device(struct udev_device *udev_device) {
893897
assert(udev_device);
894898

895899
return udev_device->device;

src/libudev/libudev-enumerate.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ struct udev_enumerate {
4949
*
5050
* Returns: an enumeration context.
5151
**/
52-
_public_ struct udev_enumerate *udev_enumerate_new(struct udev *udev) {
52+
_public_ struct udev_enumerate* udev_enumerate_new(struct udev *udev) {
5353
_cleanup_(sd_device_enumerator_unrefp) sd_device_enumerator *e = NULL;
5454
_cleanup_(udev_list_freep) struct udev_list *list = NULL;
5555
struct udev_enumerate *udev_enumerate;
@@ -81,7 +81,7 @@ _public_ struct udev_enumerate *udev_enumerate_new(struct udev *udev) {
8181
return udev_enumerate;
8282
}
8383

84-
static struct udev_enumerate *udev_enumerate_free(struct udev_enumerate *udev_enumerate) {
84+
static struct udev_enumerate* udev_enumerate_free(struct udev_enumerate *udev_enumerate) {
8585
assert(udev_enumerate);
8686

8787
udev_list_free(udev_enumerate->devices_list);
@@ -117,7 +117,7 @@ DEFINE_PUBLIC_TRIVIAL_REF_UNREF_FUNC(struct udev_enumerate, udev_enumerate, udev
117117
*
118118
* Returns: a pointer to the context.
119119
*/
120-
_public_ struct udev *udev_enumerate_get_udev(struct udev_enumerate *udev_enumerate) {
120+
_public_ struct udev* udev_enumerate_get_udev(struct udev_enumerate *udev_enumerate) {
121121
assert_return_errno(udev_enumerate, NULL, EINVAL);
122122

123123
return udev_enumerate->udev;
@@ -131,7 +131,7 @@ _public_ struct udev *udev_enumerate_get_udev(struct udev_enumerate *udev_enumer
131131
*
132132
* Returns: a udev_list_entry.
133133
*/
134-
_public_ struct udev_list_entry *udev_enumerate_get_list_entry(struct udev_enumerate *udev_enumerate) {
134+
_public_ struct udev_list_entry* udev_enumerate_get_list_entry(struct udev_enumerate *udev_enumerate) {
135135
struct udev_list_entry *e;
136136

137137
assert_return_errno(udev_enumerate, NULL, EINVAL);

src/libudev/libudev-hwdb.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ struct udev_hwdb {
3434
*
3535
* Returns: a hwdb context.
3636
**/
37-
_public_ struct udev_hwdb *udev_hwdb_new(struct udev *udev) {
37+
_public_ struct udev_hwdb* udev_hwdb_new(struct udev *udev) {
3838
_cleanup_(udev_list_freep) struct udev_list *list = NULL;
3939
_cleanup_(sd_hwdb_unrefp) sd_hwdb *hwdb_internal = NULL;
4040
struct udev_hwdb *hwdb;
@@ -61,7 +61,7 @@ _public_ struct udev_hwdb *udev_hwdb_new(struct udev *udev) {
6161
return hwdb;
6262
}
6363

64-
static struct udev_hwdb *udev_hwdb_free(struct udev_hwdb *hwdb) {
64+
static struct udev_hwdb* udev_hwdb_free(struct udev_hwdb *hwdb) {
6565
assert(hwdb);
6666

6767
sd_hwdb_unref(hwdb->hwdb);
@@ -102,7 +102,7 @@ DEFINE_PUBLIC_TRIVIAL_REF_UNREF_FUNC(struct udev_hwdb, udev_hwdb, udev_hwdb_free
102102
*
103103
* Returns: a udev_list_entry.
104104
*/
105-
_public_ struct udev_list_entry *udev_hwdb_get_properties_list_entry(struct udev_hwdb *hwdb, const char *modalias, unsigned flags) {
105+
_public_ struct udev_list_entry* udev_hwdb_get_properties_list_entry(struct udev_hwdb *hwdb, const char *modalias, unsigned flags) {
106106
const char *key, *value;
107107
struct udev_list_entry *e;
108108

src/libudev/libudev-list-internal.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77

88
struct udev_list;
99

10-
struct udev_list *udev_list_new(bool unique);
10+
struct udev_list* udev_list_new(bool unique);
1111
void udev_list_cleanup(struct udev_list *list);
12-
struct udev_list *udev_list_free(struct udev_list *list);
13-
DEFINE_TRIVIAL_CLEANUP_FUNC(struct udev_list *, udev_list_free);
12+
struct udev_list* udev_list_free(struct udev_list *list);
13+
DEFINE_TRIVIAL_CLEANUP_FUNC(struct udev_list*, udev_list_free);
1414

15-
struct udev_list_entry *udev_list_get_entry(struct udev_list *list);
16-
struct udev_list_entry *udev_list_entry_add(struct udev_list *list, const char *name, const char *value);
15+
struct udev_list_entry* udev_list_get_entry(struct udev_list *list);
16+
struct udev_list_entry* udev_list_entry_add(struct udev_list *list, const char *name, const char *value);

0 commit comments

Comments
 (0)