cmake: use PIE option specific to game building

Author: illwieckz

CMakeLists.txt

@@ -515,7 +515,7 @@ endif()
 include(DaemonNacl)
 if (NACL)
     add_library(srclibs-nacl-module EXCLUDE_FROM_ALL ${NACLLIST_MODULE})
-    set_target_properties(srclibs-nacl-module PROPERTIES POSITION_INDEPENDENT_CODE 1 FOLDER "libs")
+    set_target_properties(srclibs-nacl-module PROPERTIES POSITION_INDEPENDENT_CODE ${GAME_PIE} FOLDER "libs")
     set(LIBS_BASE ${LIBS_BASE} srclibs-nacl-module)
 else()
     add_library(srclibs-nacl-native EXCLUDE_FROM_ALL ${NACLLIST_NATIVE})
@@ -642,7 +642,7 @@ if (BUILD_CLIENT OR BUILD_TTY_CLIENT OR BUILD_SERVER OR BUILD_DUMMY_APP OR (BUIL
         find_package(ZLIB REQUIRED)
     else()
         add_library(srclibs-zlib EXCLUDE_FROM_ALL ${ZLIBLIST})
-        set_target_properties(srclibs-zlib PROPERTIES POSITION_INDEPENDENT_CODE 1 FOLDER "libs")
+        set_target_properties(srclibs-zlib PROPERTIES POSITION_INDEPENDENT_CODE ${GAME_PIE} FOLDER "libs")
         set(ZLIB_INCLUDE_DIRS ${LIB_DIR}/zlib)
         set(ZLIB_LIBRARIES srclibs-zlib)
     endif()

cmake/DaemonFlags.cmake

@@ -337,8 +337,11 @@ else()
 
 		try_c_cxx_flag(FNO_STRICT_OVERFLOW "-fno-strict-overflow")
 		try_c_cxx_flag(WSTACK_PROTECTOR "-Wstack-protector")
-		try_c_cxx_flag(FPIE "-fPIE")
-		try_linker_flag(LINKER_PIE "-pie")
+
+		if (NOT NACL OR (NACL AND GAME_PIE))
+			try_c_cxx_flag(FPIE "-fPIE")
+			try_linker_flag(LINKER_PIE "-pie")
+		endif()
 
 		if ("${FLAG_LINKER_PIE}" AND MINGW)
 			# https://github.com/msys2/MINGW-packages/issues/4100

cmake/DaemonPlatform.cmake

@@ -40,4 +40,17 @@ else()
   message( FATAL_ERROR "Platform not supported" )
 endif()
 
+if (USE_NACL_SAIGO)
+	# Saigo clang reports weird errors when building some cgame and sgame arm nexe with PIE.
+	# Saigo clang crashes when building amd64 cgame with PIE, sgame builds properly though.
+	if (NACL_TARGET STREQUAL "armhf" OR NACL_TARGET STREQUAL "amd64")
+		set(GAME_PIE 0)
+	else()
+		set(GAME_PIE 1)
+	endif()
+else()
+	set(GAME_PIE 1)
+endif()
+
+
 include(DaemonArchitecture)