Make possible to use PDCursesMod on every system #1455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PDCursesMod is forced on Windows as USE_CURSES is always enabled since there is no other console code. - PDCursesMod is used on macOS if USE_CURSES is enabled, it couldn't be enabled before as system ncurses isn't supported. - PDCursesMod is used on Linux if USE_CURSES is enabled, but USE_CURSES_NCURSES is disabled. - ncurses is used on Linux if both USE_CURSES and USE_CURSES_NCURSES are enabled. Co-authored-by: slipher <[email protected]>
illwieckz
force-pushed
the
illwieckz/pdcursesmod-everywhere
branch
2 times, most recently
from
fa5eba1 to
b92da01
Compare
Member
|
I tested on Mac and the cursor was broken. But it was easy to guess the culprit: some LGTM with the fixup |
illwieckz
force-pushed
the
illwieckz/pdcursesmod-everywhere
branch
from
d2d706f to
a376550
Compare
Member
Author
|
I confirm the PDCursesMod builds properly in the dockerized build script (and runs properly on macOS). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USE_CURSESis always enabled since there is no other console code.USE_CURSESis enabled, it couldn't be enabled before as system ncurses isn't supported.USE_CURSESis enabled, butUSE_CURSES_NCURSESis disabled.USE_CURSESandUSE_CURSES_NCURSESare enabled.See: