Skip to content

Commit 1f609b4

Browse files
authored
Merge pull request #62 from DakaraProject/python/drop-3.8
Python 3.8 drop
2 parents c016f38 + 7a76e8d commit 1f609b4

File tree

4 files changed

+15
-9
lines changed

4 files changed

+15
-9
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ jobs:
1818
- macos-latest
1919
- windows-latest
2020
python-version:
21-
- "3.8"
2221
- "3.9"
2322
- "3.10"
2423
- "3.11"

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@
3030

3131
## Unreleased
3232

33+
### Removed
34+
35+
- Dropped Python 3.8.
36+
3337
## 2.0.1 - 2024-10-28
3438

3539
### Fixed

pyproject.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,11 @@ description = "Collection of helper modules for the Dakara Project"
77
readme = "README.md"
88
license = {file = "LICENSE"}
99
dynamic = ["version"]
10-
requires-python = ">= 3.8"
10+
requires-python = ">= 3.9"
1111
classifiers = [
1212
"License :: OSI Approved :: MIT License",
1313
"Programming Language :: Python",
1414
"Programming Language :: Python :: 3",
15-
"Programming Language :: Python :: 3.8",
1615
"Programming Language :: Python :: 3.9",
1716
"Programming Language :: Python :: 3.10",
1817
"Programming Language :: Python :: 3.11",

tests/test_progress_bar.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,11 @@ def test_stderr_on_no_exception(self):
121121
# we patch `sys.stderr` as it is risky to work directly on it, and we
122122
# patch `progressbar.streams.original_stderr` as it is defined at
123123
# module loading
124-
with patch("sys.stderr", stderr), patch(
125-
"progressbar.streams.original_stderr", stderr
126-
), wrap_stderr_progressbar():
124+
with (
125+
patch("sys.stderr", stderr),
126+
patch("progressbar.streams.original_stderr", stderr),
127+
wrap_stderr_progressbar(),
128+
):
127129
wrapped_stderr = sys.stderr
128130

129131
# execute the progressbar without exception
@@ -161,9 +163,11 @@ class MyException(Exception):
161163
stderr = StringIO()
162164
initial_stderr = sys.stderr
163165

164-
with patch("sys.stderr", stderr), patch(
165-
"progressbar.streams.original_stderr", stderr
166-
), wrap_stderr_progressbar():
166+
with (
167+
patch("sys.stderr", stderr),
168+
patch("progressbar.streams.original_stderr", stderr),
169+
wrap_stderr_progressbar(),
170+
):
167171
wrapped_stderr = sys.stderr
168172

169173
# execute the progressbar with an exception

0 commit comments

Comments
 (0)