Fix/openssl connect close socket on error (aws#1939)

* Fix: Close socket on error in Openssl_Connect to prevent file descriptor leak.

* For safety, change the initial value of socketStatus to an error.

* Minor formatting

Signed-off-by: Gaurav Aggarwal <[email protected]>

* Fix formatting check

Signed-off-by: Gaurav Aggarwal <[email protected]>

---------

Signed-off-by: Gaurav Aggarwal <[email protected]>
Co-authored-by: Gaurav Aggarwal <[email protected]>

Author: YOSI-yoshidayuji

platform/posix/transport/src/openssl_posix.c

@@ -586,7 +586,7 @@ OpensslStatus_t Openssl_Connect( NetworkContext_t * pNetworkContext,
                                  uint32_t recvTimeoutMs )
 {
     OpensslParams_t * pOpensslParams = NULL;
-    SocketStatus_t socketStatus = SOCKETS_SUCCESS;
+    SocketStatus_t socketStatus = SOCKETS_CONNECT_FAILURE;
     OpensslStatus_t returnStatus = OPENSSL_SUCCESS;
     int32_t sslStatus = 0;
     uint8_t sslObjectCreated = 0;
@@ -694,6 +694,11 @@ OpensslStatus_t Openssl_Connect( NetworkContext_t * pNetworkContext,
     if( returnStatus != OPENSSL_SUCCESS )
     {
         LogError( ( "Failed to establish a TLS connection." ) );
+
+        if( socketStatus == SOCKETS_SUCCESS )
+        {
+            Sockets_Disconnect( pOpensslParams->socketDescriptor );
+        }
     }
     else
     {