fix: remove github auth token requirement (github#28)

* fix: remove github auth token requirement

Author: designcode

cmd/create/main.go

@@ -136,8 +136,17 @@ func run(ctx context.Context, buildURL, name, category, userProvidedImage string
 			gitURL += ":" + directory
 		}
 
-		cmd := exec.CommandContext(ctx, "docker", "buildx", "build", "--secret", "id=GIT_AUTH_TOKEN", "-t", "check", "-t", tag, "--label", "org.opencontainers.image.revision="+sha, gitURL)
-		cmd.Env = []string{"GIT_AUTH_TOKEN=" + os.Getenv("GITHUB_TOKEN"), "PATH=" + os.Getenv("PATH")}
+		var cmd *exec.Cmd
+		token := os.Getenv("GITHUB_TOKEN")
+
+		if token != "" {
+			cmd = exec.CommandContext(ctx, "docker", "buildx", "build", "--secret", "id=GIT_AUTH_TOKEN", "-t", "check", "-t", tag, "--label", "org.opencontainers.image.revision="+sha, gitURL)
+			cmd.Env = []string{"GIT_AUTH_TOKEN=" + token, "PATH=" + os.Getenv("PATH")}
+		} else {
+			cmd = exec.CommandContext(ctx, "docker", "buildx", "build", "-t", "check", "-t", tag, "--label", "org.opencontainers.image.revision="+sha, gitURL)
+			cmd.Env = []string{"PATH=" + os.Getenv("PATH")}
+		}
+
 		cmd.Dir = os.TempDir()
 		cmd.Stdout = os.Stdout
 		cmd.Stderr = os.Stderr
@@ -154,76 +163,75 @@ func run(ctx context.Context, buildURL, name, category, userProvidedImage string
 		return fmt.Errorf("getting working directory: %w\n%s", err, out)
 	}
 
-	
-		var (
-			secrets []servers.Secret
-			env     []servers.Env
-			command []string
-		)
-		for i := 0; i < len(args); i += 1 {
-			if args[i] == "-e" {
-				kv := args[i+1]
-				parts := strings.SplitN(kv, "=", 2)
-
-				if strings.HasSuffix(parts[0], "_TOKEN") || strings.HasSuffix(parts[0], "_KEY") || strings.HasSuffix(parts[0], "_PASSWORD"){
-					secrets = append(secrets, servers.Secret{
-						Name:    secretName(name, parts[0]),
-						Env:     parts[0],
-						Example: "<" + parts[0] + ">",
-					})
-				} else {
-					env = append(env, servers.Env{
-						Name:    parts[0],
-						Example: parts[1],
-					})
-				}
-				i += 1
+	var (
+		secrets []servers.Secret
+		env     []servers.Env
+		command []string
+	)
+	for i := 0; i < len(args); i += 1 {
+		if args[i] == "-e" {
+			kv := args[i+1]
+			parts := strings.SplitN(kv, "=", 2)
+
+			if strings.HasSuffix(parts[0], "_TOKEN") || strings.HasSuffix(parts[0], "_KEY") || strings.HasSuffix(parts[0], "_PASSWORD") {
+				secrets = append(secrets, servers.Secret{
+					Name:    secretName(name, parts[0]),
+					Env:     parts[0],
+					Example: "<" + parts[0] + ">",
+				})
 			} else {
-				command = append(command, args[i])
+				env = append(env, servers.Env{
+					Name:    parts[0],
+					Example: parts[1],
+				})
 			}
+			i += 1
+		} else {
+			command = append(command, args[i])
 		}
+	}
 
-		icon, err := client.FindIcon(ctx, refProjectURL)
-		if err != nil {
-			return err
-		}
+	icon, err := client.FindIcon(ctx, refProjectURL)
+	if err != nil {
+		return err
+	}
 
-		if branch == "main" {
-			branch = ""
-		}
+	if branch == "main" {
+		branch = ""
+	}
 
-		env, schema := servers.CreateSchema(name, env)
-
-		server := servers.Server{
-			Name:  name,
-			Image: tag,
-			Type:  "server",
-			Meta: servers.Meta{
-				Category: category,
-				Tags:     tags,
-			},
-			About: servers.About{
-				Icon:        icon,
-				Title:       title,
-				Description: "TODO (only to provide a better description than the upstream project)",
-			},
-			Source: servers.Source{
-				Project:   projectURL,
-				Upstream:  upstream,
-				Branch:    branch,
-				Directory: directory,
-			},
-			Run: servers.Run{
-				Command: command,
-			},
-			Config: servers.Config{
-				Description: "Configure the connection to TODO",
-				Secrets:     secrets,
-				Env:         env,
-				Parameters:  schema,
-			},
-		}
-		if listTools {
+	env, schema := servers.CreateSchema(name, env)
+
+	server := servers.Server{
+		Name:  name,
+		Image: tag,
+		Type:  "server",
+		Meta: servers.Meta{
+			Category: category,
+			Tags:     tags,
+		},
+		About: servers.About{
+			Icon:        icon,
+			Title:       title,
+			Description: "TODO (only to provide a better description than the upstream project)",
+		},
+		Source: servers.Source{
+			Project:   projectURL,
+			Upstream:  upstream,
+			Branch:    branch,
+			Directory: directory,
+		},
+		Run: servers.Run{
+			Command: command,
+		},
+		Config: servers.Config{
+			Description: "Configure the connection to TODO",
+			Secrets:     secrets,
+			Env:         env,
+			Parameters:  schema,
+		},
+	}
+	if listTools {
 		tools, err := mcp.Tools(ctx, server, false, false, false)
 		if err != nil {
 			return err
@@ -239,31 +247,31 @@ func run(ctx context.Context, buildURL, name, category, userProvidedImage string
 
 		fmt.Printf("\n-----------------------------------------\n\n")
 	}
-		if exists, err := checkLocalServerExists(name); err != nil {
-			return err
-		} else if exists {
-			fmt.Printf("[WARNING] Server for %s already exists, overwriting...\n", name)
-		}
+	if exists, err := checkLocalServerExists(name); err != nil {
+		return err
+	} else if exists {
+		fmt.Printf("[WARNING] Server for %s already exists, overwriting...\n", name)
+	}
 
-		serverDir := filepath.Join("servers", server.Name)
-		_ = os.Mkdir(serverDir, 0755)
+	serverDir := filepath.Join("servers", server.Name)
+	_ = os.Mkdir(serverDir, 0755)
 
-		serverFile := filepath.Join(serverDir, "server.yaml")
+	serverFile := filepath.Join(serverDir, "server.yaml")
 
-		var buf bytes.Buffer
-		encoder := yaml.NewEncoder(&buf)
-		encoder.SetIndent(2)
-		if err := encoder.Encode(server); err != nil {
-			return err
-		}
+	var buf bytes.Buffer
+	encoder := yaml.NewEncoder(&buf)
+	encoder.SetIndent(2)
+	if err := encoder.Encode(server); err != nil {
+		return err
+	}
 
-		if err := os.WriteFile(serverFile, buf.Bytes(), 0644); err != nil {
-			return fmt.Errorf("writing server config: %w", err)
-		}
+	if err := os.WriteFile(serverFile, buf.Bytes(), 0644); err != nil {
+		return fmt.Errorf("writing server config: %w", err)
+	}
 
-		fmt.Printf("Server definition written to %s.\n", serverFile)
+	fmt.Printf("Server definition written to %s.\n", serverFile)
 
-		fmt.Printf(`
+	fmt.Printf(`
 -----------------------------------------
 
 What to do next?
@@ -283,7 +291,6 @@ What to do next?
 
   5. Open a Pull Request with the %[2]s file.
 `, name, serverFile)
-	
 
 	return nil
 }

pkg/github/github.go

@@ -45,8 +45,13 @@ func NewFromServer(server servers.Server) *Client {
 }
 
 func New() *Client {
+	token := os.Getenv("GITHUB_TOKEN")
+	if token == "" {
+		return NewUnauthenticated()
+	}
+
 	return &Client{
-		gh: github.NewClient(nil).WithAuthToken(os.Getenv("GITHUB_TOKEN")),
+		gh: github.NewClient(nil).WithAuthToken(token),
 	}
 }