applied feedback

Author: neverlish

clone-graph/neverlish.go

@@ -1,3 +1,7 @@
+// A: node 의 갯수, B: neighbors의 길이
+// 시간복잡도: O(A + B)
+// 공간복잡도: O(A + B)
+
 package main
 
 import "testing"

longest-common-subsequence/neverlish.go

@@ -26,21 +26,19 @@ func Test_longestCommonSubsequence(t *testing.T) {
 }
 
 func longestCommonSubsequence(text1 string, text2 string) int {
-	commonSubsequence := make([][]int, len(text1)+1)
+	prev := make([]int, len(text2)+1)
+	curr := make([]int, len(text2)+1)
 
-	for i := 0; i < len(text1)+1; i++ {
-		commonSubsequence[i] = make([]int, len(text2)+1)
-	}
-
-	for i := 1; i < len(text1)+1; i++ {
-		for j := 1; j < len(text2)+1; j++ {
+	for i := 1; i <= len(text1); i++ {
+		for j := 1; j <= len(text2); j++ {
 			if text1[i-1] == text2[j-1] {
-				commonSubsequence[i][j] = commonSubsequence[i-1][j-1] + 1
+				curr[j] = prev[j-1] + 1
 			} else {
-				commonSubsequence[i][j] = max(commonSubsequence[i-1][j], commonSubsequence[i][j-1])
+				curr[j] = max(prev[j], curr[j-1])
 			}
 		}
+		prev, curr = curr, prev
 	}
 
-	return commonSubsequence[len(text1)][len(text2)]
+	return prev[len(text2)]
 }

sum-of-two-integers/neverlish.go

@@ -1,4 +1,4 @@
-// 시간복잡도: O(1)
+// 시간복잡도: O(log n)
 // 공간복잡도: O(1)
 
 package main