From d3859b69f13b87314f1ea885fbc21b088fe2dde1 Mon Sep 17 00:00:00 2001 From: bky373 Date: Tue, 20 Aug 2024 23:05:03 +0900 Subject: [PATCH 1/3] ci: add permissions on contents and pull-requests --- .github/workflows/integration.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/integration.yaml b/.github/workflows/integration.yaml index cff96df39..b838d3286 100644 --- a/.github/workflows/integration.yaml +++ b/.github/workflows/integration.yaml @@ -3,6 +3,10 @@ name: 🔄 Integration on: pull_request: +permissions: + contents: write + pull-requests: write + jobs: linelint: runs-on: ubuntu-latest From 34a8f369e7781ba9e926c13036e4c7b0c171d7c4 Mon Sep 17 00:00:00 2001 From: bky373 Date: Tue, 20 Aug 2024 23:09:18 +0900 Subject: [PATCH 2/3] ci: remove catch block to recognize failure --- .github/workflows/integration.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/integration.yaml b/.github/workflows/integration.yaml index b838d3286..abf6dfff2 100644 --- a/.github/workflows/integration.yaml +++ b/.github/workflows/integration.yaml @@ -85,5 +85,5 @@ jobs: } } - run().catch(err => console.error(err)); + run(); " From 9d47d88e48e9227c4cd37c92c6c19cdc969dc6e4 Mon Sep 17 00:00:00 2001 From: bky373 Date: Thu, 22 Aug 2024 23:17:29 +0900 Subject: [PATCH 3/3] ci: apply review --- .github/workflows/integration.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/integration.yaml b/.github/workflows/integration.yaml index abf6dfff2..f924e0c28 100644 --- a/.github/workflows/integration.yaml +++ b/.github/workflows/integration.yaml @@ -3,10 +3,6 @@ name: 🔄 Integration on: pull_request: -permissions: - contents: write - pull-requests: write - jobs: linelint: runs-on: ubuntu-latest @@ -17,6 +13,11 @@ jobs: label-lang: runs-on: ubuntu-latest continue-on-error: true + + permissions: + contents: write + pull-requests: write + steps: - name: Checkout code uses: actions/checkout@v4