Merge pull request #110 from DanCardin/dc/quote-trigger-names

fix: Quote trigger name/tablenames.

Author: DanCardin

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## 0.15
 
+### 0.15.9
+
+- fix: Quote trigger name/tablenames.
+
 ### 0.15.8
 
 - fix: Snowflake - Stop asserting views start with SELECT (CTEs).

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "sqlalchemy-declarative-extensions"
-version = "0.15.8"
+version = "0.15.9"
 authors = [
     {name = "Dan Cardin", email = "[email protected]"},
 ]

src/sqlalchemy_declarative_extensions/dialects/postgresql/trigger.py

@@ -155,11 +155,11 @@ def to_sql_create(self, replace=False):
             components.append("OR REPLACE")
 
         components.append("TRIGGER")
-        components.append(self.name)
+        components.append(f'"{self.name}"')
         components.append(self.time.value)
         components.append(" OR ".join([e.value for e in self.events]))
         components.append("ON")
-        components.append(self.on)
+        components.append(f'"{self.on}"')
         components.append("FOR EACH")
         components.append(self.for_each.value)
 

src/sqlalchemy_declarative_extensions/view/ddl.py

@@ -10,9 +10,7 @@
 
 def view_ddl(views: Views, view_filter: list[str] | None = None):
     def after_create(metadata: MetaData, connection: Connection, **_):
-        result = compare_views(
-            connection, views, normalize_with_connection=False
-        )
+        result = compare_views(connection, views, normalize_with_connection=False)
         for op in result:
             if not match_name(op.view.qualified_name, view_filter):
                 continue

tests/audit/test_quoting.py

@@ -0,0 +1,33 @@
+from pytest_mock_resources import create_postgres_fixture
+from sqlalchemy.orm import Mapped, mapped_column
+
+from sqlalchemy_declarative_extensions import (
+    declarative_database,
+    register_sqlalchemy_events,
+)
+from sqlalchemy_declarative_extensions.audit import audit
+from sqlalchemy_declarative_extensions.sqlalchemy import declarative_base
+
+_Base = declarative_base()
+
+
+@declarative_database
+class Base(_Base):  # type: ignore  # type: ignore
+    __abstract__ = True
+
+
+@audit()
+class Something(Base):
+    __tablename__ = "Something"
+
+    id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True)
+
+
+register_sqlalchemy_events(Base.metadata, functions=True, triggers=True)
+
+pg = create_postgres_fixture(engine_kwargs={"echo": True}, session=True)
+
+
+def test_quoted_name(pg):
+    Base.metadata.create_all(bind=pg.connection())
+    pg.commit()