feat: increase browser timeouts #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roo-code-dan[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
|
|
||
| // Timeout constants | ||
| const BROWSER_NAVIGATION_TIMEOUT = 15_000 // 15 seconds | ||
| const BROWSER_NAVIGATION_TIMEOUT = 20_000 // 20 seconds |
There was a problem hiding this comment.
P2 - Missing justification for timeout values
The timeout was increased from 15s to 20s, but there's no explanation for why 20s was chosen. Consider:
- What specific scenarios were timing out at 15s?
- Is 20s based on empirical data or testing?
- Could this mask underlying performance issues?
Adding a comment explaining the rationale would help future maintainers understand this choice.
Comment on lines
258
to
+259
| await pWaitFor(() => Date.now() - lastLogTs >= 500, { | ||
| timeout: 3_000, | ||
| timeout: 5_000, |
There was a problem hiding this comment.
P2 - Potential timeout collision
This console inactivity timeout is now 5s, which matches the default timeout in waitTillHTMLStable() (line 425). If both are waiting simultaneously, they could expire at the same time, making it unclear which timeout caused a failure.
Consider either:
- Using different timeout values (e.g., 4s here, 5s in waitTillHTMLStable)
- Adding distinct error messages to differentiate timeout sources
- Documenting the relationship between these timeouts
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased timeouts for better browser reliability