Skip to content

Commit 0f994fa

Browse files
tustvoldalamb
authored andcommitted
Remove parquet arrow_cast dependency (apache#9077)
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Arrow_cast is fairly heavy dependency, especially now that it bundles in arrow-ord for RunEndEncodedArrays (apache#8708). Removing this dependency has been discussed as far back as 2024, let's finally actually do it apache#4764. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? Yes, unfortunately apache#8524 added an API that allows overriding the inferred schema, which in turn allows the coercion machinery to traverse somewhat unintended paths. I personally think this API shouldn't exist, but... <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> --------- Co-authored-by: Andrew Lamb <[email protected]>
1 parent 6bfd685 commit 0f994fa

File tree

4 files changed

+426
-505
lines changed

4 files changed

+426
-505
lines changed

parquet/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ ahash = { version = "0.8", default-features = false, features = ["runtime-rng"]
3939
[dependencies]
4040
arrow-array = { workspace = true, optional = true }
4141
arrow-buffer = { workspace = true, optional = true }
42-
arrow-cast = { workspace = true, optional = true }
4342
arrow-csv = { workspace = true, optional = true }
4443
arrow-data = { workspace = true, optional = true }
4544
arrow-schema = { workspace = true, optional = true }
@@ -91,6 +90,7 @@ lz4_flex = { version = "0.12", default-features = false, features = ["std", "fra
9190
zstd = { version = "0.13", default-features = false }
9291
serde_json = { version = "1.0", features = ["std"], default-features = false }
9392
arrow = { workspace = true, features = ["ipc", "test_utils", "prettyprint", "json"] }
93+
arrow-cast = { workspace = true }
9494
tokio = { version = "1.0", default-features = false, features = ["macros", "rt-multi-thread", "io-util", "fs"] }
9595
rand = { version = "0.9", default-features = false, features = ["std", "std_rng", "thread_rng"] }
9696
object_store = { version = "0.12.0", default-features = false, features = ["azure", "fs"] }
@@ -104,7 +104,7 @@ default = ["arrow", "snap", "brotli", "flate2-zlib-rs", "lz4", "zstd", "base64",
104104
# Enable lz4
105105
lz4 = ["lz4_flex"]
106106
# Enable arrow reader/writer APIs
107-
arrow = ["base64", "arrow-array", "arrow-buffer", "arrow-cast", "arrow-data", "arrow-schema", "arrow-select", "arrow-ipc"]
107+
arrow = ["base64", "arrow-array", "arrow-buffer", "arrow-data", "arrow-schema", "arrow-select", "arrow-ipc"]
108108
# Enable support for arrow canonical extension types
109109
arrow_canonical_extension_types = ["arrow-schema?/canonical_extension_types"]
110110
# Enable CLI tools

0 commit comments

Comments
 (0)