Skip to content

Commit 5afc323

Browse files
committed
Merge branch 'master' into fix-deprecation
# Conflicts: # charts/redis-ha/Chart.yaml
2 parents 7ced598 + 97435f6 commit 5afc323

12 files changed

+44
-11
lines changed

.github/workflows/test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
fail-fast: false
1414
matrix:
15-
kubernetesVersion: ["v1.29.2", "v1.26.14"]
15+
kubernetesVersion: ["v1.31.13", "v1.34.1"]
1616
runs-on: ubuntu-latest
1717
if: github.ref != 'refs/heads/master'
1818
steps:

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@
33
### Charts for numerous projects. Migrated from `helm/stable` due to deprecation timeline.
44

55
Charts are deployed via Github Actions to the `gh-pages` branch.
6+

charts/redis-ha/Chart.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
apiVersion: v2
22
name: redis-ha
3-
home: http://redis.io/
3+
home: https://redis.io/
44
keywords:
55
- redis
66
- keyvalue
77
- database
8-
version: 4.33.9
9-
appVersion: 7.2.7
8+
version: 4.34.4
9+
appVersion: 8.2.1
1010
description: This Helm chart provides a highly available Redis implementation with a master/slave configuration and uses Sentinel sidecars for failover management
11-
icon: https://upload.wikimedia.org/wikipedia/en/thumb/6/6b/Redis_Logo.svg/1200px-Redis_Logo.svg.png
11+
icon: https://img.icons8.com/external-tal-revivo-shadow-tal-revivo/24/external-redis-an-in-memory-data-structure-project-implementing-a-distributed-logo-shadow-tal-revivo.png
1212
maintainers:
1313
- email: aaron.layfield@gmail.com
1414
name: dandydeveloper

charts/redis-ha/README.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ The following table lists the configurable parameters of the Redis chart and the
8787
| `hostPath.path` | Use this path on the host for data storage. path is evaluated as template so placeholders are replaced | string | `""` |
8888
| `image.pullPolicy` | Redis image pull policy | string | `"IfNotPresent"` |
8989
| `image.repository` | Redis image repository | string | `"public.ecr.aws/docker/library/redis"` |
90-
| `image.tag` | Redis image tag | string | `"7.2.7-alpine"` |
90+
| `image.tag` | Redis image tag | string | `"8.2.1-alpine"` |
9191
| `imagePullSecrets` | Reference to one or more secrets to be used when pulling redis images | list | `[]` |
9292
| `init.resources` | Extra init resources | object | `{}` |
9393
| `labels` | Custom labels for the redis pod | object | `{}` |
@@ -242,6 +242,7 @@ The following table lists the configurable parameters of the Redis chart and the
242242
| `haproxy.containerPort` | Modify HAProxy deployment container port | int | `6379` |
243243
| `haproxy.containerSecurityContext` | Security context to be added to the HAProxy containers. | object | `{"allowPrivilegeEscalation":false,"capabilities":{"drop":["ALL"]},"runAsNonRoot":true,"seccompProfile":{"type":"RuntimeDefault"}}` |
244244
| `haproxy.customConfig` | Allows for custom config-haproxy.cfg file to be applied. If this is used then default config will be overwriten | string | `nil` |
245+
| `haproxy.deploymentAnnotations` | HAProxy template deployment annotations | object | `{}` |
245246
| `haproxy.deploymentStrategy` | Deployment strategy for the haproxy deployment | object | `{"type":"RollingUpdate"}` |
246247
| `haproxy.emptyDir` | Configuration of `emptyDir` | object | `{}` |
247248
| `haproxy.enabled` | Enabled HAProxy LoadBalancing/Proxy | bool | `false` |
@@ -484,3 +485,12 @@ As a result, from this version onwards Kubernetes versions older than 1.19 will
484485

485486
----------------------------------------------
486487
Autogenerated from chart metadata using [helm-docs](https://github.com/norwoodj/helm-docs)
488+
489+
## 4.34.1 - Upgrade may complain about selector label changes being immutable
490+
This version introduced changes to the selector labels for the Deployments. Depending on the policies in your cluster, you may see an error like this when upgrading:
491+
492+
```
493+
Error: UPGRADE FAILED: cannot patch "redis-redis-ha-haproxy" with kind Deployment: Deployment.apps "redis-redis-ha-haproxy" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"redis-ha-haproxy", "component":"haproxy", "release":"redis"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable
494+
```
495+
496+
In these cases, you'll need to delete the Deployment for the haproxy, or simple do a forceful upgrade.

charts/redis-ha/templates/redis-haproxy-deployment.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,16 @@ metadata:
66
namespace: {{ .Release.Namespace | quote }}
77
labels:
88
{{ include "labels.standard" . | indent 4 }}
9+
component: haproxy
910
{{- range $key, $value := .Values.extraLabels }}
1011
{{ $key }}: {{ $value | quote }}
1112
{{- end }}
13+
{{- if .Values.haproxy.deploymentAnnotations }}
14+
annotations:
15+
{{- range $key, $value := .Values.haproxy.deploymentAnnotations }}
16+
{{ $key }}: {{ $value | quote }}
17+
{{- end }}
18+
{{- end }}
1219
spec:
1320
{{- with .Values.haproxy.deploymentStrategy }}
1421
strategy:
@@ -20,12 +27,14 @@ spec:
2027
matchLabels:
2128
app: {{ template "redis-ha.name" . }}-haproxy
2229
release: {{ .Release.Name }}
30+
component: haproxy
2331
template:
2432
metadata:
2533
name: {{ template "redis-ha.fullname" . }}-haproxy
2634
labels:
2735
app: {{ template "redis-ha.name" . }}-haproxy
2836
release: {{ .Release.Name }}
37+
component: haproxy
2938
{{- range $key, $value := .Values.haproxy.labels }}
3039
{{ $key }}: {{ $value | toString }}
3140
{{- end }}
@@ -71,6 +80,7 @@ spec:
7180
matchLabels:
7281
app: {{ template "redis-ha.name" . }}-haproxy
7382
release: {{ .Release.Name }}
83+
component: haproxy
7484
topologyKey: kubernetes.io/hostname
7585
{{- else }}
7686
preferredDuringSchedulingIgnoredDuringExecution:
@@ -80,6 +90,7 @@ spec:
8090
matchLabels:
8191
app: {{ template "redis-ha.name" . }}-haproxy
8292
release: {{ .Release.Name }}
93+
component: haproxy
8394
topologyKey: kubernetes.io/hostname
8495
{{- end }}
8596
{{- end }}
@@ -92,6 +103,7 @@ spec:
92103
matchLabels:
93104
app: {{ template "redis-ha.name" . }}-haproxy
94105
release: {{ .Release.Name }}
106+
component: haproxy
95107
{{- end }}
96108
initContainers:
97109
- name: config-init

charts/redis-ha/templates/redis-haproxy-network-policy.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ spec:
2121
matchLabels:
2222
release: {{ .Release.Name }}
2323
app: {{ template "redis-ha.name" . }}-haproxy
24+
component: haproxy
2425
policyTypes:
2526
- Ingress
2627
- Egress

charts/redis-ha/templates/redis-haproxy-pdb.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,6 @@ spec:
1414
matchLabels:
1515
release: {{ .Release.Name }}
1616
app: {{ template "redis-ha.name" . }}-haproxy
17+
component: haproxy
1718
{{ toYaml .Values.haproxy.podDisruptionBudget | indent 2 }}
1819
{{- end -}}

charts/redis-ha/templates/redis-haproxy-role.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ metadata:
77
namespace: {{ .Release.Namespace | quote }}
88
labels:
99
{{ include "labels.standard" . | indent 4 }}
10-
component: {{ template "redis-ha.fullname" . }}-haproxy
10+
component: haproxy
1111
{{- range $key, $value := .Values.extraLabels }}
1212
{{ $key }}: {{ $value | quote }}
1313
{{- end }}

charts/redis-ha/templates/redis-haproxy-rolebinding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ metadata:
77
namespace: {{ .Release.Namespace | quote }}
88
labels:
99
{{ include "labels.standard" . | indent 4 }}
10-
component: {{ template "redis-ha.fullname" . }}-haproxy
10+
component: haproxy
1111
{{- range $key, $value := .Values.extraLabels }}
1212
{{ $key }}: {{ $value | quote }}
1313
{{- end }}

charts/redis-ha/templates/redis-haproxy-service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
namespace: {{ .Release.Namespace | quote }}
77
labels:
88
{{ include "labels.standard" . | indent 4 }}
9-
component: {{ template "redis-ha.fullname" . }}-haproxy
9+
component: haproxy
1010
{{- range $key, $value := .Values.extraLabels }}
1111
{{ $key }}: {{ $value | quote }}
1212
{{- end }}

0 commit comments

Comments
 (0)