fix build break due to commit 05d03e7 (cloudnativelabs#817)

murali-reddy · web-flow · commit 3a0da2bf9a8a · 2019-12-09T19:53:23.000+05:30
diff --git a/pkg/controllers/proxy/network_services_controller.go b/pkg/controllers/proxy/network_services_controller.go
@@ -507,7 +507,7 @@ func (nsc *NetworkServicesController) setupIpvsFirewall() error {
 	}
 
 	// config.IpvsPermitAll: true then create INPUT/KUBE-ROUTER-SERVICE Chain creation else return
-	if !config.ipvsPermitAll {
+	if !nsc.ipvsPermitAll {
 		return nil
 	}
 
@@ -519,7 +519,7 @@ func (nsc *NetworkServicesController) setupIpvsFirewall() error {
 	args = []string{"-m", "comment", "--comment", comment,
 		"-m", "set", "--match-set", ipvsServicesIPSetName, "dst,dst",
 		"-j", "ACCEPT"}
-	exists, err := iptablesCmdHandler.Exists("filter", ipvsFirewallChainName, args...)
+	exists, err = iptablesCmdHandler.Exists("filter", ipvsFirewallChainName, args...)
 	if err != nil {
 		return fmt.Errorf("Failed to run iptables command: %s", err.Error())
 	}

Original file line number	Diff line number	Diff line change
`@@ -507,7 +507,7 @@ func (nsc *NetworkServicesController) setupIpvsFirewall() error {`
`507`	`507`	`}`
`508`	`508`
`509`	`509`	`// config.IpvsPermitAll: true then create INPUT/KUBE-ROUTER-SERVICE Chain creation else return`
`510`		`- if !config.ipvsPermitAll {`
	`510`	`+ if !nsc.ipvsPermitAll {`
`511`	`511`	`return nil`
`512`	`512`	`}`
`513`	`513`
`@@ -519,7 +519,7 @@ func (nsc *NetworkServicesController) setupIpvsFirewall() error {`
`519`	`519`	`args = []string{"-m", "comment", "--comment", comment,`
`520`	`520`	`"-m", "set", "--match-set", ipvsServicesIPSetName, "dst,dst",`
`521`	`521`	`"-j", "ACCEPT"}`
`522`		`- exists, err := iptablesCmdHandler.Exists("filter", ipvsFirewallChainName, args...)`
	`522`	`+ exists, err = iptablesCmdHandler.Exists("filter", ipvsFirewallChainName, args...)`
`523`	`523`	`if err != nil {`
`524`	`524`	`return fmt.Errorf("Failed to run iptables command: %s", err.Error())`
`525`	`525`	`}`