update biome to v2, run all checks

Author: Dane-2pi

.github/workflows/ci.yml

@@ -12,12 +12,12 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup Biome
-        uses: biomejs/setup-biome@v1
+        uses: biomejs/setup-biome@v2
         with:
           version: latest
 
       - name: Run Biome
-        run: biome ci .
+        run: biome ci
   build:
     runs-on: ubuntu-latest
     steps:

biome.json

@@ -1,8 +1,6 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.5.0/schema.json",
-  "organizeImports": {
-    "enabled": true
-  },
+  "$schema": "https://biomejs.dev/schemas/2.0.6/schema.json",
+  "assist": { "actions": { "source": { "organizeImports": "on" } } },
   "files": {
     "ignoreUnknown": true
   },
@@ -20,10 +18,19 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "all": true,
       "style": {
-        "useNamingConvention": "off"
+        "useNamingConvention": "off",
+        "noParameterAssign": "error",
+        "useAsConstAssertion": "error",
+        "useDefaultParameterLast": "error",
+        "useEnumInitializers": "error",
+        "useSelfClosingElements": "error",
+        "useSingleVarDeclarator": "error",
+        "noUnusedTemplateLiteral": "error",
+        "useNumberNamespace": "error",
+        "noInferrableTypes": "error",
+        "noUselessElse": "error"
       }
     }
   }
-}
+}

package-lock.json

@@ -34,7 +34,7 @@
     "typescript": "^5.3.3"
   },
   "devDependencies": {
-    "@biomejs/biome": "1.9.4",
+    "@biomejs/biome": "2.0.6",
     "@buf/meshtastic_protobufs.bufbuild_es": "1.7.2-20240216123215-6b07c41c68c9.1",
     "@types/node": "^20.11.19",
     "prisma": "^5.9.1",

package.json

@@ -1,19 +1,18 @@
+import { GatewayService } from "@buf/meshtastic_api.connectrpc_es/protobufs/gateway/v1/gateway_service_connect.js";
+import { expressConnectMiddleware } from "@connectrpc/connect-express";
 import { App } from "@tinyhttp/app";
 import { cors } from "@tinyhttp/cors";
 import { config } from "@tinyhttp/dotenv";
-import { logger } from "@tinyhttp/logger";
 import { favicon } from "@tinyhttp/favicon";
-
+import { logger } from "@tinyhttp/logger";
+import { RegisterMqttClient } from "./lib/index.js";
 import {
   FirmwareRoutes,
   GithubRoutes,
+  MqttRoutes,
   ResourceRoutes,
   UpdaterRoutes,
-  MqttRoutes,
 } from "./routes/index.js";
-import { RegisterMqttClient } from "./lib/index.js";
-import { expressConnectMiddleware } from "@connectrpc/connect-express";
-import { GatewayService } from "@buf/meshtastic_api.connectrpc_es/protobufs/gateway/v1/gateway_service_connect.js";
 import { Gateway } from "./services/index.js";
 
 export const app = new App();

src/index.ts

@@ -1,7 +1,6 @@
-import { Octokit } from "octokit";
-
 import { createAppAuth } from "@octokit/auth-app";
 import { config } from "@tinyhttp/dotenv";
+import { Octokit } from "octokit";
 
 const DEVICE_OWNER = "meshtastic";
 const DEVICE_REPO = "firmware";

src/lib/github.ts

@@ -1,5 +1,5 @@
 export * as GitHub from "./github.js";
-export * as Hardware from "./resource.js";
-export { redis } from "./redis.js";
 export { RegisterMqttClient } from "./mqtt.js";
 export { prisma } from "./prisma.js";
+export { redis } from "./redis.js";
+export * as Hardware from "./resource.js";

src/lib/index.ts

@@ -1,5 +1,5 @@
-import MQTT from "mqtt";
 import { Protobuf } from "@meshtastic/js";
+import MQTT from "mqtt";
 import { prisma, redis } from "./index.js";
 
 const mqtt = MQTT.connect(process.env.MQTT_URL as string, {
@@ -22,13 +22,10 @@ export const RegisterMqttClient = () => {
         const decoded = Protobuf.Mqtt.ServiceEnvelope.fromBinary(payload);
         queue.push(decoded);
       } catch (error) {
-        // biome-ignore lint/suspicious/noConsole: fix soon
         console.error(error, topic, payload);
       }
     } else {
       // Likely stat message
-      // biome-ignore lint/suspicious/noConsoleLog: fix soon
-      // biome-ignore lint/suspicious/noConsole: fix soon
       console.log("Unknown topic", topic);
     }
   });
@@ -138,8 +135,6 @@ class MqttQueue {
 
     for (const gateway of toProcess) {
       for (const channel of gateway.channels) {
-        // biome-ignore lint/suspicious/noConsoleLog: fix soon
-        // biome-ignore lint/suspicious/noConsole: fix soon
         console.log(
           "Queue:",
           this.queue.length,

src/lib/mqtt.ts

@@ -1,4 +1,5 @@
 import Prisma from "@prisma/client";
+
 const { PrismaClient } = Prisma;
 
 export const prisma = new PrismaClient();

src/lib/prisma.ts

@@ -1,5 +1,5 @@
 export { FirmwareRoutes } from "./firmware.js";
 export { GithubRoutes } from "./github.js";
+export { MqttRoutes } from "./mqtt.js";
 export { ResourceRoutes } from "./resource.js";
 export { UpdaterRoutes } from "./updater.js";
-export { MqttRoutes } from "./mqtt.js";