refactor: prepare reconciliation infrastructure with improved status handling and event filtering

- Refactor status handling from strings to structured conditions (StagingCondition, TriggerCondition)
- Add dedicated status files with condition constants for type safety
- Add SetStatus helper methods for cleaner status updates
- Implement event filtering with predicates to focus reconciliation on relevant changes:
  - GenerationChangedPredicate for spec changes
  - AnnotationChangedPredicate for annotation updates
- Add RBAC permissions for batch/jobs resources

Author: DanielBlei

Makefile

@@ -7,8 +7,6 @@ help: ## Display this help.
 
 ##@ Pipeline Forge Development
 
-.PHONY: test
-test: test-operator ## Run Pipeline Forge tests
 
 .PHONY: dev-up
 dev-up: ## Start development environment with docker-compose (dev/)

operator/Makefile

@@ -29,7 +29,7 @@ manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and Cust
 
 .PHONY: generate
 generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
-	$(CONTROLLER_GEN) object:headerFile="../hack/boilerplate.go.txt" paths="./..."
+	$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."
 
 .PHONY: fmt
 fmt: ## Run go fmt against code.

operator/api/v1alpha1/staging_status.go

@@ -0,0 +1,13 @@
+package v1alpha1
+
+type StagingCondition string
+
+const (
+	StagingStatusCompleted     StagingCondition = "Completed"
+	StagingConditionFailed     StagingCondition = "Failed"
+	StagingConditionPending    StagingCondition = "Pending"
+	StagingConditionRunning    StagingCondition = "Running"
+	StagingConditionSuspended  StagingCondition = "Suspended"
+	StagingConditionReady      StagingCondition = "Ready"
+	StagingConditionInitiating StagingCondition = "Initiating"
+)

operator/api/v1alpha1/staging_types.go

@@ -220,7 +220,7 @@ type StagingSpec struct {
 // +kubebuilder:object:generate=true
 type InternalStatus struct {
 	// Status of the associated staging object (e.g., Complete, Running, Failed, Pending, Unknown).
-	Status string `json:"status,omitempty"`
+	Status *StagingCondition `json:"status,omitempty"`
 
 	// Message provides additional information or error messages about the step status.
 	Message string `json:"message,omitempty"`
@@ -260,7 +260,7 @@ type InternalStatus struct {
 type StagingStatus struct {
 	// Status is the status of the Staging (e.g., Deployed, Failed, Pending, Running).
 	// +kubebuilder:validation:Enum=Pending;Running;Completed;Failed;Suspended;Unknown
-	Status StatusType `json:"status,omitempty"`
+	Status *StagingCondition `json:"status,omitempty"`
 
 	// ObservedGeneration is the most recent generation observed by the controller.
 	ObservedGeneration int64 `json:"observedGeneration,omitempty"`
@@ -306,6 +306,11 @@ type StagingList struct {
 	Items           []Staging `json:"items"`
 }
 
+// SetStatus is a helper function to set the staging status condition
+func (s *StagingStatus) SetStatus(condition StagingCondition) {
+	s.Status = &condition
+}
+
 func init() {
 	SchemeBuilder.Register(&Staging{}, &StagingList{})
 }

operator/api/v1alpha1/trigger_status.go

@@ -0,0 +1,13 @@
+package v1alpha1
+
+type TriggerCondition string
+
+const (
+	TriggerStatusCompleted     TriggerCondition = "Completed"
+	TriggerConditionFailed     TriggerCondition = "Failed"
+	TriggerConditionPending    TriggerCondition = "Pending"
+	TriggerConditionRunning    TriggerCondition = "Running"
+	TriggerConditionSuspended  TriggerCondition = "Suspended"
+	TriggerConditionReady      TriggerCondition = "Ready"
+	TriggerConditionInitiating TriggerCondition = "Initiating"
+)

operator/api/v1alpha1/trigger_types.go

@@ -175,8 +175,10 @@ type TriggerSpec struct {
 // +kubebuilder:object:generate=true
 type TriggerStatus struct {
 	// Status is the status of the Trigger (e.g., Deployed, Failed, Pending, Running).
-	// +kubebuilder:validation:Enum=Pending;Running;Completed;Failed;Suspended;Unknown
-	Status string `json:"status,omitempty"`
+	Status *TriggerCondition `json:"status,omitempty"`
+
+	// ObservedGeneration is the most recent generation observed by the controller.
+	ObservedGeneration int64 `json:"observedGeneration,omitempty"`
 
 	// Conditions represent the latest available observations of the trigger's state.
 	// Examples: Ready, Failed, CooldownActive
@@ -240,7 +242,7 @@ type Trigger struct {
 	Spec TriggerSpec `json:"spec"`
 
 	// status defines the observed state of Trigger
-	Status StatusType `json:"status,omitempty,omitzero"`
+	Status TriggerStatus `json:"status,omitempty,omitzero"`
 }
 
 // +kubebuilder:object:root=true
@@ -252,6 +254,11 @@ type TriggerList struct {
 	Items           []Trigger `json:"items"`
 }
 
+// SetStatus is a helper function to set the trigger status condition
+func (t *TriggerStatus) SetStatus(condition TriggerCondition) {
+	t.Status = &condition
+}
+
 func init() {
 	SchemeBuilder.Register(&Trigger{}, &TriggerList{})
 }

operator/api/v1alpha1/zz_generated.deepcopy.go

@@ -251,7 +251,129 @@ spec:
             type: object
           status:
             description: status defines the observed state of Trigger
-            type: string
+            properties:
+              attempts:
+                description: Attempts tracks the number of times this step has been
+                  attempted.
+                format: int32
+                type: integer
+              conditions:
+                description: |-
+                  Conditions represent the latest available observations of the trigger's state.
+                  Examples: Ready, Failed, CooldownActive
+                items:
+                  description: Condition contains details for one aspect of the current
+                    state of this API Resource.
+                  properties:
+                    lastTransitionTime:
+                      description: |-
+                        lastTransitionTime is the last time the condition transitioned from one status to another.
+                        This should be when the underlying condition changed.  If that is not known, then using the time when the API field changed is acceptable.
+                      format: date-time
+                      type: string
+                    message:
+                      description: |-
+                        message is a human readable message indicating details about the transition.
+                        This may be an empty string.
+                      maxLength: 32768
+                      type: string
+                    observedGeneration:
+                      description: |-
+                        observedGeneration represents the .metadata.generation that the condition was set based upon.
+                        For instance, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date
+                        with respect to the current state of the instance.
+                      format: int64
+                      minimum: 0
+                      type: integer
+                    reason:
+                      description: |-
+                        reason contains a programmatic identifier indicating the reason for the condition's last transition.
+                        Producers of specific condition types may define expected values and meanings for this field,
+                        and whether the values are considered a guaranteed API.
+                        The value should be a CamelCase string.
+                        This field may not be empty.
+                      maxLength: 1024
+                      minLength: 1
+                      pattern: ^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$
+                      type: string
+                    status:
+                      description: status of the condition, one of True, False, Unknown.
+                      enum:
+                      - "True"
+                      - "False"
+                      - Unknown
+                      type: string
+                    type:
+                      description: type of condition in CamelCase or in foo.example.com/CamelCase.
+                      maxLength: 316
+                      pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
+                      type: string
+                  required:
+                  - lastTransitionTime
+                  - message
+                  - reason
+                  - status
+                  - type
+                  type: object
+                type: array
+              cooldownUntil:
+                description: CooldownUntil is the next eligible time this trigger
+                  can fire, based on Cooldown setting.
+                format: date-time
+                type: string
+              failedAttempts:
+                description: FailedAttempts tracks the number of failed attempts.
+                format: int32
+                type: integer
+              lastAttemptTime:
+                description: LastAttemptTime is the timestamp of the last attempt.
+                format: date-time
+                type: string
+              lastCheckTime:
+                description: LastCheckTime is the last time the controller evaluated
+                  whether to trigger.
+                format: date-time
+                type: string
+              lastFailureTime:
+                description: LastFailureTime is the timestamp of the last failure.
+                format: date-time
+                type: string
+              lastRunJobName:
+                description: LastRunJobName is the name of the last Kubernetes Job
+                  created by this trigger.
+                type: string
+              lastTriggeredTime:
+                description: LastTriggeredTime is the last time this trigger successfully
+                  resulted in a pipeline activation.
+                format: date-time
+                type: string
+              maxRetries:
+                description: MaxRetries defines the maximum number of retries allowed.
+                format: int32
+                type: integer
+              message:
+                description: Message provides human-readable information about the
+                  trigger status or last evaluation.
+                type: string
+              observedGeneration:
+                description: ObservedGeneration is the most recent generation observed
+                  by the controller.
+                format: int64
+                type: integer
+              retryCount:
+                description: RetryCount tracks the number of retries for the current
+                  attempt.
+                format: int32
+                type: integer
+              status:
+                description: Status is the status of the Trigger (e.g., Deployed,
+                  Failed, Pending, Running).
+                type: string
+              successfulAttempts:
+                description: SuccessfulAttempts tracks the number of successful attempts.
+                format: int32
+                type: integer
+            type: object
         required:
         - spec
         type: object

operator/config/crd/bases/core.pipeline-forge.io_triggers.yaml

@@ -4,6 +4,14 @@ kind: ClusterRole
 metadata:
   name: manager-role
 rules:
+- apiGroups:
+  - batch
+  resources:
+  - jobs
+  verbs:
+  - get
+  - list
+  - watch
 - apiGroups:
   - core.pipeline-forge.io
   resources:

operator/config/rbac/role.yaml

@@ -0,0 +1,15 @@
+/*
+Copyright 2025 Daniel Blei.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/