Skip to content

Commit a0e8d4f

Browse files
Tyler NowickiDanielCChen
authored andcommitted
[Coroutines] Improve use of unique_ptr (llvm#111870)
* Replace usage of unique_ptr<>(new ...) -> make_unique<>();
1 parent c87b8e3 commit a0e8d4f

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

llvm/lib/Transforms/Coroutines/CoroSplit.cpp

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2211,17 +2211,13 @@ CreateNewABI(Function &F, coro::Shape &S,
22112211

22122212
switch (S.ABI) {
22132213
case coro::ABI::Switch:
2214-
return std::unique_ptr<coro::BaseABI>(
2215-
new coro::SwitchABI(F, S, IsMatCallback));
2214+
return std::make_unique<coro::SwitchABI>(F, S, IsMatCallback);
22162215
case coro::ABI::Async:
2217-
return std::unique_ptr<coro::BaseABI>(
2218-
new coro::AsyncABI(F, S, IsMatCallback));
2216+
return std::make_unique<coro::AsyncABI>(F, S, IsMatCallback);
22192217
case coro::ABI::Retcon:
2220-
return std::unique_ptr<coro::BaseABI>(
2221-
new coro::AnyRetconABI(F, S, IsMatCallback));
2218+
return std::make_unique<coro::AnyRetconABI>(F, S, IsMatCallback);
22222219
case coro::ABI::RetconOnce:
2223-
return std::unique_ptr<coro::BaseABI>(
2224-
new coro::AnyRetconABI(F, S, IsMatCallback));
2220+
return std::make_unique<coro::AnyRetconABI>(F, S, IsMatCallback);
22252221
}
22262222
llvm_unreachable("Unknown ABI");
22272223
}

llvm/unittests/Transforms/Coroutines/ExtraRematTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ TEST_F(ExtraRematTest, TestCoroRematWithCustomABI) {
247247
ASSERT_TRUE(M);
248248

249249
CoroSplitPass::BaseABITy GenCustomABI = [](Function &F, coro::Shape &S) {
250-
return std::unique_ptr<coro::BaseABI>(new ExtraCustomABI(F, S));
250+
return std::make_unique<ExtraCustomABI>(F, S);
251251
};
252252

253253
CGSCCPassManager CGPM;

0 commit comments

Comments
 (0)