ext/zlib: Refactor tests (php#18887)

- Use INI sections
- Use CGI sections
- Move data into a subfolder
- Remove ZPP tests
- Fix various bugs within tests
- Simplify some


Found while working on php#18879

Author: Girgias

ext/zlib/tests/002.phpt

@@ -8,14 +8,14 @@ $original = str_repeat("hallo php",4096);
 $packed=gzcompress($original);
 echo strlen($packed)." ".strlen($original)."\n";
 $unpacked=gzuncompress($packed);
-if (strcmp($original,$unpacked)==0) echo "Strings are equal\n";
+if ($original === $unpacked) echo "Strings are equal\n";
 
 /* with explicit compression level, length */
 $original = str_repeat("hallo php",4096);
 $packed=gzcompress($original, 9);
 echo strlen($packed)." ".strlen($original)."\n";
 $unpacked=gzuncompress($packed, 40000);
-if (strcmp($original,$unpacked)==0) echo "Strings are equal\n";
+if ($original === $unpacked) echo "Strings are equal\n";
 ?>
 --EXPECT--
 106 36864

ext/zlib/tests/003.phpt

@@ -7,7 +7,7 @@ zlib
 $original = str_repeat("hallo php",4096);
 $packed = gzencode($original);
 echo strlen($packed)." ".strlen($original). "\n";
-if (strcmp($original, gzdecode($packed)) == 0) echo "Strings are equal";
+if ($original === gzdecode($packed)) echo "Strings are equal\n";
 ?>
 --EXPECT--
 118 36864

ext/zlib/tests/bug55544-win.phpt

@@ -2,14 +2,13 @@
 checks zlib compression output size is always the same
 --EXTENSIONS--
 zlib
+--INI--
+zlib.output_compression=4096
+zlib.output_compression_level=9
 --CGI--
 --FILE--
 <?php
 
-// the INI directives from bug #60761 report
-ini_set('zlib.output_compression', '4096');
-ini_set('zlib.output_compression_level', '9');
-
 // try to duplicate the original bug by running this as a CGI
 // test using ob_start and zlib.output_compression(or ob_gzhandler)
 // so it follows more of the original code-path than just calling

ext/zlib/tests/bug60761.phpt

@@ -9,7 +9,7 @@ gzopen('someFile', 'c');
 ?>
 --CLEAN--
 <?php
-    unlink('someFile');
+unlink('someFile');
 ?>
 --EXPECTF--
 Warning: gzopen(): gzopen failed in %s on line %d

ext/zlib/tests/bug61139.phpt

@@ -45,7 +45,7 @@ function test($case) {
     // The gzdecode() function applied to the corrupted compressed data always
     // detects the error:
     // --> gzdecode(): PHP Fatal error:  Uncaught ErrorException: gzdecode(): data error in ...
-    echo "gzdecode(): ", rawurldecode(gzdecode($compressed)), "\n";
+    echo "gzdecode(): ", rawurldecode((string) gzdecode($compressed)), "\n";
 
     file_put_contents($fn, $compressed);
 

ext/zlib/tests/bug71417.phpt

@@ -2,11 +2,11 @@
 Bug #74240 (deflate_add can allocate too much memory)
 --EXTENSIONS--
 zlib
+--INI--
+memory_limit=64M
 --FILE--
 <?php
 
-ini_set('memory_limit', '64M');
-
 $deflator = deflate_init(ZLIB_ENCODING_RAW);
 
 $bytes = str_repeat("*", 65536);

ext/zlib/tests/bug74240.phpt

@@ -4,16 +4,14 @@ compress.zlib:// wrapper
 zlib
 --FILE--
 <?php
-chdir(__DIR__. "/../../..");
-
-$pfx = str_repeat('../', substr_count($_SERVER['PHP_SELF'], '../'));
+chdir(__DIR__. "/data");
 
 // Relative path
-$fp = fopen("compress.zlib://{$pfx}ext/xsl/tests/xslt.xsl.gz", "rb");
+$fp = fopen("compress.zlib://test.txt.gz", "rb");
 fclose($fp);
 
 // Absolute path
-$fp = fopen("compress.zlib://". __DIR__. "/../../../ext/xsl/tests/xslt.xsl.gz", "rb");
+$fp = fopen("compress.zlib://". __DIR__. "/data/test.txt.gz", "rb");
 fclose($fp);
 
 echo "ok\n";