Use RETURN_NEW_STR() in url.c

ndossche · ndossche · commit 68794e074b2f · 2025-04-22T18:41:45.000+02:00
This avoids an extra branch.
diff --git a/ext/standard/url.c b/ext/standard/url.c
@@ -559,7 +559,7 @@ PHP_FUNCTION(urlencode)
 		Z_PARAM_STR(in_str)
 	ZEND_PARSE_PARAMETERS_END();
 
-	RETURN_STR(php_url_encode(ZSTR_VAL(in_str), ZSTR_LEN(in_str)));
+	RETURN_NEW_STR(php_url_encode(ZSTR_VAL(in_str), ZSTR_LEN(in_str)));
 }
 /* }}} */
 
@@ -621,7 +621,7 @@ PHP_FUNCTION(rawurlencode)
 		Z_PARAM_STR(in_str)
 	ZEND_PARSE_PARAMETERS_END();
 
-	RETURN_STR(php_raw_url_encode(ZSTR_VAL(in_str), ZSTR_LEN(in_str)));
+	RETURN_NEW_STR(php_raw_url_encode(ZSTR_VAL(in_str), ZSTR_LEN(in_str)));
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -559,7 +559,7 @@ PHP_FUNCTION(urlencode)`
`559`	`559`	`Z_PARAM_STR(in_str)`
`560`	`560`	`ZEND_PARSE_PARAMETERS_END();`
`561`	`561`
`562`		`- RETURN_STR(php_url_encode(ZSTR_VAL(in_str), ZSTR_LEN(in_str)));`
	`562`	`+ RETURN_NEW_STR(php_url_encode(ZSTR_VAL(in_str), ZSTR_LEN(in_str)));`
`563`	`563`	`}`
`564`	`564`	`/* }}} */`
`565`	`565`
`@@ -621,7 +621,7 @@ PHP_FUNCTION(rawurlencode)`
`621`	`621`	`Z_PARAM_STR(in_str)`
`622`	`622`	`ZEND_PARSE_PARAMETERS_END();`
`623`	`623`
`624`		`- RETURN_STR(php_raw_url_encode(ZSTR_VAL(in_str), ZSTR_LEN(in_str)));`
	`624`	`+ RETURN_NEW_STR(php_raw_url_encode(ZSTR_VAL(in_str), ZSTR_LEN(in_str)));`
`625`	`625`	`}`
`626`	`626`	`/* }}} */`
`627`	`627`