better SearchSimilarNames

Author: DanielFillol

controllers/controller.go

@@ -10,6 +10,8 @@ import (
 	"strings"
 )
 
+const leveinshtein = 0.8
+
 //CreateName create new name on database of type NameType
 func CreateName(c *gin.Context) {
 	var name models.NameType
@@ -89,39 +91,37 @@ func SearchSimilarNames(c *gin.Context) {
 
 	//Name to be searched
 	name := c.Params.ByName("name")
-	mtf := metaphone.Pack(name)
-
-	database.Db.Where("metaphone = ?", metaphone.Pack(name)).Find(&names)
-
-	if len(names) == 0 {
-		c.JSON(http.StatusNotFound, gin.H{"Not found": "metaphone not found", "metaphone": mtf})
-		return
-	}
+	database.Db.Find(&names)
 
+	mtf := metaphone.Pack(name)
 	var similarNames []string
 	for _, n := range names {
-		if metaphone.SimilarityBetweenWords(strings.ToLower(name), strings.ToLower(n.Name)) >= 0.8 {
-			similarNames = append(similarNames, n.Name)
-			varWords := strings.Split(n.NameVariations, "|")
-			for _, vw := range varWords {
-				if vw != "" {
-					similarNames = append(similarNames, strings.TrimSpace(vw))
+		if metaphone.IsMetaphoneSimilar(mtf, n.Metaphone) {
+			if metaphone.SimilarityBetweenWords(strings.ToLower(name), strings.ToLower(n.Name)) >= leveinshtein {
+				similarNames = append(similarNames, n.Name)
+				varWords := strings.Split(n.NameVariations, "|")
+				for _, vw := range varWords {
+					if vw != "" {
+						similarNames = append(similarNames, strings.TrimSpace(vw))
+					}
 				}
 			}
-		}
-
-		if len(similarNames) == 0 {
-			similarNames = append(similarNames, n.Name)
-			varWords := strings.Split(n.NameVariations, "|")
-			for _, vw := range varWords {
-				if vw != "" {
-					similarNames = append(similarNames, strings.TrimSpace(vw))
+			if len(similarNames) == 0 {
+				similarNames = append(similarNames, n.Name)
+				varWords := strings.Split(n.NameVariations, "|")
+				for _, vw := range varWords {
+					if vw != "" {
+						similarNames = append(similarNames, strings.TrimSpace(vw))
+					}
 				}
 			}
+			sort.Strings(similarNames)
 		}
+	}
 
-		sort.Strings(similarNames)
-
+	if len(names) == 0 {
+		c.JSON(http.StatusNotFound, gin.H{"Not found": "metaphone not found", "metaphone": mtf})
+		return
 	}
 
 	c.JSON(200, gin.H{