Skip to content

Conversation

@DanielNoord
Copy link
Owner

Closes #489

I guess that regex was always doomed to fail.

This should fix it. There are some weird changes that I don't particularly like.

For example, capitalization in """'A.m.' or 'p.m.'.""" is not desired I think...
Also """"""a.m.""" or "p.m.".""" is invalid syntax.

However, we have always said that we can't format everything perfectly and "crap in is crap out". Since this at least fixes the bug I think it is still an improvement.

@DanielNoord DanielNoord added the bug Something isn't working label Jul 12, 2025
@github-actions
Copy link

According to the primer, this change has no effect on the checked open source code. 🤖🎉

@codecov
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (13d4261) to head (f40b910).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #491   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1126      1126           
  Branches       120       120           
=========================================
  Hits          1126      1126           
Flag Coverage Δ
linux 98.93% <100.00%> (ø)
windows 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pydocstringformatter/_formatting/base.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanielNoord DanielNoord merged commit 5a56060 into main Jul 12, 2025
17 checks passed
@DanielNoord DanielNoord deleted the single-quotes-bug branch July 12, 2025 08:39
@DanielNoord
Copy link
Owner Author

#493 fixes the 'A.m.' formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single quotes in triple-quoted docstring raise AssertionError

2 participants