Extract browser logic (#3)

Co-authored-by: Jadhiel Vélez <[email protected]>

Author: DannyFeliz

create-pull-request.js

@@ -4,33 +4,38 @@ const exec = util.promisify(require("child_process").exec);
 const gitRemoteOriginUrl = require("git-remote-origin-url");
 const open = require("open");
 
+function getBrowser() {
+  const browsers = [
+    { id: "chrome", value: "chrome" },
+    { id: "firefox", value: "firefox" },
+    { id: "edge", value: "msedge" },
+    { id: "safari", value: "safari" },
+    { id: "ie", value: "iexplore" },
+    { id: "opera", value: "opera" }
+  ];
+
+  let [, , browser = ""] = process.argv;
+
+  if (browser) {
+    browser = browsers.find(({ id }) => id == browser.toLowerCase());
+    browser = browser ? browser.value : "";
+  }
+
+  return browser;
+}
+
 (async () => {
   try {
     const { stdout, stderr } = await exec("git rev-parse --abbrev-ref HEAD");
     if (stderr) {
       throw stderr;
     }
-
-    const browsers = [
-      { id: "chrome", value: "chrome" },
-      { id: "firefox", value: "firefox" },
-      { id: "edge", value: "msedge" },
-      { id: "safari", value: "safari" },
-      { id: "ie", value: "iexplore" },
-      { id: "opera", value: "opera" }
-    ];
-
     const branchName = stdout.trim();
     const remoteOriginUrl = await gitRemoteOriginUrl();
     const newPullRequestUrl = `https://${remoteOriginUrl.replace("git@", "").replace(":", "/").replace(/\.git$/, "")}/pull/new/${branchName}`;
-    let [,, browser = ""] = process.argv;
-
-    if (browser) {
-      browser = browsers.find(({ id }) => id == browser.toLowerCase());
-      browser = browser ? browser.value : "";
-    }
+    const browser = getBrowser();
 
-    await open(newPullRequestUrl, {app: browser});
+    await open(newPullRequestUrl, { app: browser });
   } catch (error) {
     throw error;
   }