Address review feedback: workflow_dispatch, JDK 8, --batch-mode, env vars for secrets, curl error handling

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Author: Copilot

.github/workflows/deploy.yml

@@ -17,17 +17,20 @@
 
 name: Deploy Plugin to omcsi
 
-# Trigger on all pushes; the job condition below restricts execution to the
-# configured branch.  Note: ${{ vars.* }} expressions are NOT evaluated inside
-# the `on:` event filter – only inside job steps and conditions.
+# Trigger on pushes (branch-gated via the job condition) and on manual runs
+# via the "Run workflow" button in the Actions tab.
+# Note: ${{ vars.* }} expressions are NOT evaluated inside the `on:` event
+# filter – only inside job steps and conditions.
 on:
   push:
+  workflow_dispatch:
 
 jobs:
   build-and-deploy:
     name: Build and Deploy Plugin
-    # Only run when the pushed branch matches DEPLOY_BRANCH (default: main)
-    if: ${{ github.ref_name == (vars.DEPLOY_BRANCH || 'main') }}
+    # Run on manual dispatch (any branch) or when the pushed branch matches
+    # DEPLOY_BRANCH (default: main).
+    if: ${{ github.event_name == 'workflow_dispatch' || github.ref_name == (vars.DEPLOY_BRANCH || 'main') }}
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -36,14 +39,14 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Set up JDK 21
+      - name: Set up JDK 8
         uses: actions/setup-java@v4
         with:
           distribution: temurin
-          java-version: '21'
+          java-version: '8'
 
       - name: Build plugin JAR
-        run: mvn package
+        run: mvn --batch-mode package
 
       - name: Locate built JAR
         id: locate-jar
@@ -63,29 +66,42 @@ jobs:
           echo "✅ Found JAR: ${JAR_FILE}"
 
       - name: Deploy plugin to omcsi
+        env:
+          DEPLOY_TOKEN: ${{ secrets.OMCSI_DEPLOY_TOKEN }}
+          DEPLOY_URL: ${{ secrets.OMCSI_DEPLOY_URL }}
+          JAR_FILE: ${{ steps.locate-jar.outputs.jar_file }}
         run: |
           PLUGIN_JAR_NAME="${{ vars.PLUGIN_JAR_NAME }}"
           if [ -z "${PLUGIN_JAR_NAME}" ]; then
             echo "❌ PLUGIN_JAR_NAME variable is not set"
             exit 1
           fi
 
-          HTTP_STATUS=$(curl --silent --output /dev/null --write-out "%{http_code}" \
+          RESPONSE_BODY=$(mktemp)
+          trap 'rm -f "${RESPONSE_BODY}"' EXIT
+          HTTP_STATUS=$(curl --silent --write-out "%{http_code}" \
+            --output "${RESPONSE_BODY}" \
             --request POST \
-            --header "Authorization: Bearer ${{ secrets.OMCSI_DEPLOY_TOKEN }}" \
+            --header "Authorization: Bearer ${DEPLOY_TOKEN}" \
             --form "pluginName=${PLUGIN_JAR_NAME}" \
-            --form "file=@${{ steps.locate-jar.outputs.jar_file }}" \
-            "${{ secrets.OMCSI_DEPLOY_URL }}/api/plugins/deploy")
+            --form "file=@${JAR_FILE}" \
+            "${DEPLOY_URL}/api/plugins/deploy") || {
+            echo "❌ curl failed – network error or invalid URL"
+            exit 1
+          }
 
           if [ "${HTTP_STATUS}" -eq 200 ]; then
             echo "✅ Plugin deployed successfully (HTTP ${HTTP_STATUS})"
           elif [ "${HTTP_STATUS}" -eq 401 ]; then
             echo "❌ Authentication failed – check OMCSI_DEPLOY_TOKEN (HTTP ${HTTP_STATUS})"
+            echo "Response body:"; cat "${RESPONSE_BODY}"
             exit 1
           elif [ "${HTTP_STATUS}" -eq 400 ]; then
             echo "❌ Bad request – check PLUGIN_JAR_NAME and the uploaded JAR (HTTP ${HTTP_STATUS})"
+            echo "Response body:"; cat "${RESPONSE_BODY}"
             exit 1
           else
             echo "❌ Deployment failed (HTTP ${HTTP_STATUS})"
+            echo "Response body:"; cat "${RESPONSE_BODY}"
             exit 1
           fi