Skip to content

Commit ebbeddf

Browse files
author
BuildTools
committed
Merge branch 'copilot/fix-751a9037-3a32-417b-8065-948a85ffe2bd' of github.com:Dans-Plugins/SimpleSkills into copilot/fix-751a9037-3a32-417b-8065-948a85ffe2bd
2 parents 4486143 + 7bbf0ca commit ebbeddf

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

src/main/java/dansplugins/simpleskills/commands/ForceCommand.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ private boolean forceActivate(CommandSender commandSender, String skillName) {
9191
}
9292
skill.setActive(true);
9393
configService.setSkillActive(skill.getName(), true);
94-
commandSender.sendMessage(ChatColor.GREEN + "The '" + skill.getName() + "' is now active.");
94+
commandSender.sendMessage(ChatColor.GREEN + "The '" + skill.getName() + "' skill is now active. A server restart is required for this change to take full effect.");
9595
return true;
9696
}
9797

@@ -111,7 +111,7 @@ private boolean forceDeactivate(CommandSender commandSender, String skillName) {
111111
}
112112
skill.setActive(false);
113113
configService.setSkillActive(skill.getName(), false);
114-
commandSender.sendMessage(ChatColor.GREEN + "The '" + skill.getName() + "' is now inactive.");
114+
commandSender.sendMessage(ChatColor.GREEN + "The '" + skill.getName() + "' skill is now inactive.");
115115
return true;
116116
}
117117
}

src/main/java/dansplugins/simpleskills/skill/abs/AbstractSkill.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public AbstractSkill(ConfigService configService, Log log, PlayerRecordRepositor
8383
if (triggers.length == 0) throw new IllegalArgumentException("Skill cannot have zero triggers.");
8484
this.name = name;
8585
// Read activation state from config, default to true for backward compatibility
86-
this.active = this.configService.getConfig().getBoolean("skills." + name + ".active", true);
86+
this.active = this.configService.getConfig().getBoolean("skills." + getName() + ".active", true);
8787
this.expReq = this.configService.getConfig().getInt("defaultBaseExperienceRequirement", 10);
8888
this.expFactor = this.configService.getConfig().getDouble("defaultDefaultExperienceIncreaseFactor", 1.2);
8989
setupTriggers(triggers);
@@ -128,6 +128,7 @@ private void setupTriggers(@NotNull Class<? extends Event>[] triggers) {
128128
* @param event to handle.
129129
*/
130130
public void handle(Event event) {
131+
if (!active) return;
131132
if (calledEvents.contains(event)) return;
132133
calledEvents.add(event);
133134
if (event instanceof Cancellable) if (((Cancellable) event).isCancelled()) return;

src/main/resources/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ skills:
3636
active: true
3737
Mining:
3838
active: true
39-
MonsterHunting:
39+
"Monster Hunting":
4040
active: true
4141
Pyromaniac:
4242
active: true
@@ -46,5 +46,5 @@ skills:
4646
active: true
4747
Strength:
4848
active: true
49-
Woodcutting:
49+
Lumberjack:
5050
active: true

0 commit comments

Comments
 (0)