-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Description
Currently there are a bunch of lines like
NexusDashboard/app/__init__.py
Lines 233 to 236 in 2e4bd04
| app.config['REQUIRE_PLAY_KEY'] = os.getenv( | |
| 'REQUIRE_PLAY_KEY', | |
| app.config['REQUIRE_PLAY_KEY'] | |
| ) |
in
app/__init__.py
Given that os.getenv returns either the default or a string and
$ python3
>>> bool("")
False
>>> bool("1")
True
>>> bool("0")
True
>>> bool("True")
True
>>> bool("False")
True
this may not be the best way to parse boolean type values, because an if on just the value may cause unituitive configuration.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels