Removing lots of console logging that isn't needed anymore

Author: Darkside138

gradle.properties

@@ -1,2 +1,2 @@
-projectVersion=4.1.46
+projectVersion=4.1.47
 org.gradle.configuration-cache=false

src/frontend/src/components/ContextMenu.tsx

@@ -78,21 +78,17 @@ export function ContextMenu({
 
     // Block if we just sent a request within the last 300ms
     if (now - lastUpdateTimeRef.current < 300) {
-      console.log('Blocked duplicate API call (too soon)');
       return;
     }
 
     // Block if this exact value was already sent
     if (lastSentValueRef.current === newValue) {
-      console.log('Blocked duplicate API call (same value)');
       return;
     }
 
     lastUpdateTimeRef.current = now;
     setIsUpdating(true);
 
-    console.log(`Calling API to update volume offset to ${newValue}%`);
-
     try {
       const url = new URL(`${API_BASE_URL}/api/soundFiles/${soundId}`, window.location.origin);
       url.searchParams.append('volumeOffsetPercentage', newValue.toString());
@@ -107,17 +103,13 @@ export function ContextMenu({
       });
 
       if (!response.ok) {
-        console.error('Failed to update volume offset:', response.status, response.statusText);
-        // Revert to original value on error
         setLocalVolumeOffset(volumeOffset ?? 0);
         toast.error('Failed to update volume offset');
       } else {
         lastSentValueRef.current = newValue;
         toast.success('Volume offset updated');
       }
-    } catch (error) {
-      console.error('Error updating volume offset:', error);
-      // Revert to original value on error
+    } catch {
       setLocalVolumeOffset(volumeOffset ?? 0);
       toast.error('Failed to update volume offset');
     } finally {
@@ -130,20 +122,14 @@ export function ContextMenu({
   };
 
   const handleVolumeRelease = () => {
-    console.log('handleVolumeRelease called');
-
-    // Only update if the value has changed from what we last sent
     if (localVolumeOffset !== lastSentValueRef.current) {
       updateVolumeOffset(localVolumeOffset);
-    } else {
-      console.log('No change in volume, skipping API call');
     }
   };
 
   // Update display name on the backend
   const updateDisplayName = async (newName: string) => {
     setIsUpdatingName(true);
-    console.log(`Calling API to update display name to: ${newName}`);
 
     try {
       const url = new URL(`${API_BASE_URL}/api/soundFiles/${soundId}`, window.location.origin);
@@ -159,18 +145,13 @@ export function ContextMenu({
       });
 
       if (!response.ok) {
-        console.error('Failed to update display name:', response.status, response.statusText);
-        // Revert to original value on error
         setEditedDisplayName(displayName || '');
         toast.error('Failed to update display name');
       } else {
-        console.log('Display name updated successfully');
         setSavedDisplayName(newName);
         toast.success('Display name updated');
       }
-    } catch (error) {
-      console.error('Error updating display name:', error);
-      // Revert to original value on error
+    } catch {
       setEditedDisplayName(displayName || '');
       toast.error('Failed to update display name');
     } finally {

src/frontend/src/hooks/__tests__/useVolume.test.ts

@@ -80,7 +80,6 @@ describe('useVolume', () => {
   })
 
   it('handles API errors gracefully', async () => {
-    const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
     ;(global.fetch as any).mockRejectedValueOnce(new Error('Network error'))
 
     const { result } = renderHook(() => useVolume())
@@ -89,10 +88,8 @@ describe('useVolume', () => {
       await result.current.updateVolume(80, 'user123')
     })
 
-    expect(result.current.volume).toBe(80) // Volume still updates locally
-    expect(consoleErrorSpy).toHaveBeenCalledWith('Error updating volume:', expect.any(Error))
-
-    consoleErrorSpy.mockRestore()
+    // Volume still updates locally even when API fails
+    expect(result.current.volume).toBe(80)
   })
 
   it('persists volume across remounts', () => {

src/frontend/src/hooks/usePlaybackTracking.ts

@@ -53,12 +53,7 @@ export function usePlaybackTracking({ selectedUserGuildId }: UsePlaybackTracking
     };
 
     try {
-      console.log('📡 Connecting to playback SSE endpoint:', API_ENDPOINTS.PLAYBACK_STREAM);
       playbackEventSource = new EventSource(API_ENDPOINTS.PLAYBACK_STREAM);
-      
-      playbackEventSource.onopen = () => {
-        console.log('✅ Playback SSE connection established');
-      };
 
       playbackEventSource.onerror = () => {
         // Let EventSource auto-reconnect silently
@@ -68,31 +63,28 @@ export function usePlaybackTracking({ selectedUserGuildId }: UsePlaybackTracking
         if (!isMounted) return;
         try {
           const data = JSON.parse(event.data);
-          console.log('🎵 Track started:', data);
           handleTrackStart(data);
-        } catch (error) {
-          console.error('Error parsing trackStart event:', error);
+        } catch {
+          // Ignore parse errors
         }
       });
 
       playbackEventSource.addEventListener('trackEnd', (event) => {
         if (!isMounted) return;
         try {
           const data = JSON.parse(event.data);
-          console.log('🎵 Track ended:', data);
           handleTrackEnd(data);
-        } catch (error) {
-          console.error('Error parsing trackEnd event:', error);
+        } catch {
+          // Ignore parse errors
         }
       });
-    } catch (error) {
-      console.error('Failed to create playback SSE connection:', error);
+    } catch {
+      // SSE connection failed, will retry on next mount
     }
 
     return () => {
       isMounted = false;
       if (playbackEventSource) {
-        console.log('🧹 Closing playback SSE connection');
         playbackEventSource.close();
       }
     };

src/frontend/src/hooks/useSoundActions.ts

@@ -26,23 +26,17 @@ export function useSoundActions({
   const toggleFavorite = async (soundId: string) => {
     const isFavorite = favorites.has(soundId);
     const newFavoriteState = !isFavorite;
-    const callId = Math.random().toString(36).substring(7);
-    
+
     if (toggleFavoriteInProgressRef.current.has(soundId)) {
-      console.log(`[${callId}] toggleFavorite called for ${soundId}, but a toggle is already in progress`);
       return;
     }
-    
+
     toggleFavoriteInProgressRef.current.add(soundId);
-    
+
     try {
-      console.log(`[${callId}] toggleFavorite called for ${soundId}, changing to ${newFavoriteState}`);
-      console.trace(`[${callId}] Call stack`);
-      
-      console.log(`[${callId}] About to call fetch...`);
       const response = await fetch(
         `${API_ENDPOINTS.FAVORITE}/${soundId}?favorite=${newFavoriteState}`,
-        { 
+        {
           method: 'POST',
           mode: 'cors',
           credentials: 'include',
@@ -52,10 +46,8 @@ export function useSoundActions({
           }
         }
       );
-      console.log(`[${callId}] Fetch completed, response received`);
 
       if (!response.ok) {
-        console.error(`[${callId}] Failed to update favorite status:`, response.status);
         throw new Error('Failed to update favorite status');
       }
 
@@ -66,22 +58,17 @@ export function useSoundActions({
         await response.clone().text().catch(() => {});
       }
 
-      console.log(`[${callId}] Favorite status updated successfully: ${newFavoriteState}`);
-
-      console.log(`[${callId}] Updating local favorites state...`);
       setFavorites(prev => {
         const newFavorites = new Set(prev);
         if (newFavoriteState) {
           newFavorites.add(soundId);
-          console.log(`[${callId}] Added ${soundId} to favorites. New favorites:`, Array.from(newFavorites));
         } else {
           newFavorites.delete(soundId);
-          console.log(`[${callId}] Removed ${soundId} from favorites. New favorites:`, Array.from(newFavorites));
         }
         return newFavorites;
       });
     } catch (error) {
-      console.error(`[${callId}] Error updating favorite status:`, error);
+      console.error('Error updating favorite status:', error);
       toast.error('Failed to update favorite. Please try again.', { duration: 3000 });
     } finally {
       toggleFavoriteInProgressRef.current.delete(soundId);
@@ -111,15 +98,11 @@ export function useSoundActions({
       );
 
       if (!response.ok) {
-        const errorText = await response.text().catch(() => 'Unknown error');
-        console.error(`Failed to play sound through bot: ${response.status} - ${errorText}`);
         throw new Error(`Failed to play sound through bot: ${response.status}`);
       }
 
-      console.log('Sound played successfully through bot');
       setCurrentlyPlayingSoundId(soundId);
     } catch (error) {
-      console.error('Error playing sound through bot:', error);
       if (error instanceof TypeError || (error instanceof Error && error.message.includes('Failed to play'))) {
         if (error instanceof TypeError) {
           toast.error('Failed to play sound. Please make sure the backend is running', { duration: 3000 });
@@ -148,14 +131,9 @@ export function useSoundActions({
       );
 
       if (!response.ok) {
-        const errorText = await response.text().catch(() => 'Unknown error');
-        console.error(`Failed to play random sound: ${response.status} - ${errorText}`);
         throw new Error(`Failed to play random sound: ${response.status}`);
       }
-
-      console.log('Random sound played successfully');
     } catch (error) {
-      console.error('Error playing random sound:', error);
       if (error instanceof TypeError) {
         toast.error('Failed to play random sound. Please make sure the backend is running', { duration: 3000 });
       } else if (error instanceof Error) {
@@ -182,15 +160,11 @@ export function useSoundActions({
       );
 
       if (!response.ok) {
-        const errorText = await response.text().catch(() => 'Unknown error');
-        console.error(`Failed to stop sound: ${response.status} - ${errorText}`);
         throw new Error(`Failed to stop sound: ${response.status}`);
       }
 
-      console.log('Sound stopped successfully');
       setCurrentlyPlayingSoundId(null);
     } catch (error) {
-      console.error('Error stopping sound:', error);
       if (error instanceof TypeError) {
         toast.error('Failed to stop sound. Please make sure the backend is running', { duration: 3000 });
       } else if (error instanceof Error) {
@@ -206,7 +180,6 @@ export function useSoundActions({
       });
 
       if (!response.ok) {
-        console.error('Failed to delete sound:', response.status, response.statusText);
         toast.error('Failed to delete sound', { duration: 3000 });
         return;
       }
@@ -219,8 +192,7 @@ export function useSoundActions({
       });
 
       toast.success('Sound deleted successfully', { duration: 3000 });
-    } catch (error) {
-      console.error('Error deleting sound:', error);
+    } catch {
       toast.error('Failed to delete sound', { duration: 3000 });
     }
   };
@@ -256,8 +228,6 @@ export function useSoundActions({
     formData.append('file', file);
 
     try {
-      console.log('📤 Uploading file:', file.name);
-
       const authHeaders = getAuthHeadersWithCsrf();
 
       const response = await fetch(API_ENDPOINTS.UPLOAD, {
@@ -275,17 +245,12 @@ export function useSoundActions({
       }
 
       if (!response.ok) {
-        const errorText = await response.text().catch(() => 'Unknown error');
-        console.error(`Failed to upload file: ${response.status} - ${errorText}`);
         throw new Error(`Failed to upload file: ${response.status}`);
       }
 
-      console.log('✅ File uploaded successfully');
       toast.success(`File "${file.name}" uploaded successfully!`, { duration: 3000 });
-
       event.target.value = '';
     } catch (error) {
-      console.error('Error uploading file:', error);
       if (error instanceof TypeError) {
         toast.error('Failed to upload file. Please make sure the backend is running', { duration: 3000 });
       } else if (error instanceof Error) {

src/frontend/src/hooks/useSounds.ts

@@ -71,22 +71,16 @@ export function useSounds() {
         }
       });
 
-      console.log('🔄 SSE Update - Favorites from backend:', Array.from(newFavorites));
-      console.log('🔄 SSE Update - Total sounds received:', transformedSounds.length);
-      console.log('🔄 SSE Update - Favorited sounds:', transformedSounds.filter(s => s.favorite).map(s => ({ id: s.id, favorite: s.favorite })));
-      
       setFavorites(newFavorites);
       setLoading(false);
       setConnectionStatus('connected');
     };
 
     try {
-      console.log('📡 Connecting to SSE endpoint:', API_ENDPOINTS.SOUNDS_STREAM);
       eventSource = new EventSource(API_ENDPOINTS.SOUNDS_STREAM);
-      
+
       eventSource.onopen = () => {
         if (!isMounted) return;
-        console.log('✅ SSE connection established');
         setConnectionStatus('connected');
       };
 

src/frontend/src/hooks/useVolume.ts

@@ -39,12 +39,10 @@ export function useVolume() {
       );
 
       if (!response.ok) {
-        console.error('Failed to update volume:', response.status);
-      } else {
-        console.log(`Volume updated successfully: ${newVolume}%`);
+        // Volume update failed silently
       }
-    } catch (error) {
-      console.error('Error updating volume:', error);
+    } catch {
+      // Volume update failed silently
     }
   };