Replies: 1 comment
-
I dont quite understand how you call the Request Modifier. The standard approach would be like this: https://reference.dashif.org/dash.js/nightly/samples/advanced/extend.html . In this case you can omit the |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
in reference to #3996
594767c
https://github.com/Dash-Industry-Forum/dash.js/blob/development/src/streaming/utils/RequestModifier.js
RequestModifier.modifyRequestHeader
old call was modifyRequestHeader(xhr)
same call with new prototype results in:
Uncaught TypeError: Cannot read properties of undefined (reading 'url')
at Object.modifyRequestHeader (RequestModifier.js:57:45)
A possible fix would be to set a default value as in:
modifyRequestHeader: function (xhr, {url}={}) { ... } in which url will present as undefined when not provided
or
modifyRequestHeader: function (xhr, {url=""}={}) { ... } in which url will present as empty string when not provided
Thank you for your consideration.
Beta Was this translation helpful? Give feedback.
All reactions