Skip to content

Commit e1cb2f9

Browse files
committed
Merge bitcoin#27683: ci: remove RUN_SECURITY_TESTS
6a93658 ci: remove RUN_SECURITY_TESTS (fanquake) Pull request description: We no-longer run any security/symbol checks in the CI, and doubt we will in future (if we do, it will be via Guix, where this var would be redundant in any case). ACKs for top commit: josibake: code review ACK bitcoin@6a93658 TheCharlatan: ACK 6a93658
1 parent e63410e commit e1cb2f9

File tree

4 files changed

+0
-8
lines changed

4 files changed

+0
-8
lines changed

ci/dash/build_src.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,3 @@ fi
5757
if [ "${RUN_TIDY}" = "true" ] && [ "${GITHUB_ACTIONS}" != "true" ]; then
5858
"${BASE_ROOT_DIR}/ci/dash/lint-tidy.sh"
5959
fi
60-
61-
if [ "$RUN_SECURITY_TESTS" = "true" ]; then
62-
make test-security-check
63-
fi

ci/test/00_setup_env.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ export USE_BUSY_BOX=${USE_BUSY_BOX:-false}
3939
export RUN_UNIT_TESTS=${RUN_UNIT_TESTS:-true}
4040
export RUN_FUNCTIONAL_TESTS=${RUN_FUNCTIONAL_TESTS:-true}
4141
export RUN_TIDY=${RUN_TIDY:-false}
42-
export RUN_SECURITY_TESTS=${RUN_SECURITY_TESTS:-false}
4342
# By how much to scale the test_runner timeouts (option --timeout-factor).
4443
# This is needed because some ci machines have slow CPU or disk, so sanitizers
4544
# might be slow or a reindex might be waiting on disk IO.

ci/test/00_setup_env_mac_native_x86_64.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,3 @@ export CI_OS_NAME="macos"
1515
export NO_DEPENDS=1
1616
export OSX_SDK=""
1717
export CCACHE_MAXSIZE=300M
18-
19-
export RUN_SECURITY_TESTS="true"

ci/test/00_setup_env_win64.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export HOST=x86_64-w64-mingw32
1111
export DPKG_ADD_ARCH="i386"
1212
export PACKAGES="python3 nsis g++-mingw-w64-x86-64-posix wine-binfmt wine64 wine32 file"
1313
export RUN_FUNCTIONAL_TESTS=false
14-
export RUN_SECURITY_TESTS="false"
1514
export GOAL="deploy"
1615
# Prior to 11.0.0, the mingw-w64 headers were missing noreturn attributes, causing warnings when
1716
# cross-compiling for Windows. https://sourceforge.net/p/mingw-w64/bugs/306/

0 commit comments

Comments
 (0)