Dasharo-deploy: Pass arrays instead of namerefs

Use arrays instead of namerefs in helper functions related to
dasharo-deploy. The reason is this is easier to read.

Signed-off-by: Mateusz Kusiak <mateusz.kusiak@3mdeb.com>

Author: 3mkusiak

include/dts-functions.sh

@@ -706,12 +706,12 @@ is_region_locked() {
 # 0 if found, 1 otherwise.
 flashrom_check_for_region() {
   local region="$1"
-  local -n _args="$2"
-  local i
+  shift
+  local -a args=("$@")
 
   # Iterate only up to length-1 since we inspect pairs (i, i+1)
-  for ((i = 0; i < ${#_args[@]} - 1; i++)); do
-    if [[ "${_args[i]}" == "-i" && "${_args[i + 1]}" == "$region" ]]; then
+  for ((i = 0; i < ${#args[@]} - 1; i++)); do
+    if [[ "${args[i]}" == "-i" && "${args[i + 1]}" == "$region" ]]; then
       return 0
     fi
   done
@@ -722,20 +722,20 @@ flashrom_check_for_region() {
 # Does a final check for all flashrom parameters if FD or ME are to be flashed
 # and if they're locked. Decide whether we can proceed if any regions are locked.
 flashrom_region_check() {
-  local -n args="$1"
+  local -a args=("$@")
   local locked_regions=()
   local region_list verb
 
   # If switching to heads, always check the region, otherwise check region only
   # if specified in params.
   # The reason is we want to handle both "overwrites" form metadata as well as
   # dynamically added params from set_intel_regions_update_params()
-  if (flashrom_check_for_region fd args || [[ "$SWITCHING_TO" == "heads" ]]) &&
+  if (flashrom_check_for_region fd "${args[@]}" || [[ "$SWITCHING_TO" == "heads" ]]) &&
     is_region_locked fd; then
     locked_regions+=("FD")
   fi
 
-  if (flashrom_check_for_region me args || [[ "$SWITCHING_TO" == "heads" ]]) &&
+  if (flashrom_check_for_region me "${args[@]}" || [[ "$SWITCHING_TO" == "heads" ]]) &&
     is_region_locked me; then
     locked_regions+=("ME")
   fi

scripts/dasharo-deploy.sh

@@ -1018,7 +1018,7 @@ deploy_firmware() {
     # shellcheck disable=SC2178
     local -n args_ref="_job_args_$i"
 
-    if flashrom_check_for_region fd args_ref; then
+    if flashrom_check_for_region fd "${args_ref[@]}"; then
       echo "Scheduling dedicated FD update..."
       schedule_job "Failed to flash FD" \
         -p "$PROGRAMMER_BIOS" \
@@ -1047,7 +1047,7 @@ deploy_firmware() {
   done
 
   # Last resort check before flashing
-  if ! flashrom_region_check _all_flashrom_args; then
+  if ! flashrom_region_check "${_all_flashrom_args[@]}"; then
     return 1
   fi