testflash_image_check.robot: region checks from list objects

test/common/keywords.robot: Download And Check Flash Image extended
with region list as argument and improved command line concatenation.

Signed-off-by: Mateusz Maciejewski <mateusz.maciejewski@3mdeb.com>

Author: DonVasyl

osfv_cli/test/common/keywords.robot

@@ -85,29 +85,32 @@ Check In
 Download And Check Flash Image
     [Documentation]    This keyword downloads Dasharo flash image and runs osfv_cli
     ...    with flash check command, eventually in dry mode with enforced success
-    ...    command status.
-    [Arguments]    ${image_url}    ${dry_mode}=${FALSE}
+    ...    command status. Expected regions are passed with -c options added to
+    ...    command line.
+    [Arguments]    ${image_url}    ${dry_mode}    @{regions}
     Remove Directory    ${MECHECK_TMP_DIR}    True
     Create Directory    ${MECHECK_TMP_DIR}
+
     ${wget_output}=    Run Process
     ...    wget
     ...    ${image_url}
     ...    -O
     ...    ${MECHECK_TMP_DIR}/coreboot.rom
     File Should Exist    ${MECHECK_TMP_DIR}/coreboot.rom
+
+    ${command}=    Catenate
+    ...    osfv_cli flash_image_check --rom ${MECHECK_TMP_DIR}/coreboot.rom
+
+    FOR    ${region}    IN    @{regions}
+        ${command}=    Catenate    ${command}    -c    ${region}
+    END
+
     IF    ${dry_mode} == ${TRUE}
-        ${cli_output}=    Run Process
-        ...    osfv_cli
-        ...    flash_image_check
-        ...    --rom
-        ...    ${MECHECK_TMP_DIR}/coreboot.rom
-        ...    -x
-    ELSE
-        ${cli_output}=    Run Process
-        ...    osfv_cli
-        ...    flash_image_check
-        ...    --rom
-        ...    ${MECHECK_TMP_DIR}/coreboot.rom
+        ${command}=    Catenate    ${command}    -x
     END
+
+    ${cli_output}=    Run Process
+    ...    ${command}
+    ...    shell=True
     Remove Directory    ${MECHECK_TMP_DIR}    True
     RETURN    ${cli_output}

osfv_cli/test/flash_image_check.robot

@@ -18,30 +18,40 @@ ${EXPECTED_STDOUT_SUCCESS_STRING}=      SUCCESS: region "me" is present and cont
 *** Test Cases ***
 Test Flash Check - No ME in image
     [Documentation]    Check image containing descriptor but no ME region
+    @{regions_to_check}=    Create List    me
     ${cli_check_out}=    Download And Check Flash Image
     ...    ${MECHECK_NO_ME_URL}
+    ...    ${FALSE}
+    ...    @{regions_to_check}
     Should Contain    ${cli_check_out.stderr}    ${EXPECTED_STDERR_FAILURE_STRING}
 
 Test Flash Check - Complete image
     [Documentation]    Check image containing descriptor and ME region
+    @{regions_to_check}=    Create List    me
     ${cli_check_out}=    Download And Check Flash Image
     ...    ${MECHECK_ME_URL}
+    ...    ${FALSE}
+    ...    @{regions_to_check}
     Should Not Contain    ${cli_check_out.stderr}    flash_image_check failed.
     Should Contain    ${cli_check_out.stdout}    ${EXPECTED_STDOUT_SUCCESS_STRING}
 
 Test Flash Check - No ME in image but DRY check
     [Documentation]    Check image containing descriptor but no ME region
     ...    in dry mode.
+    @{regions_to_check}=    Create List    me
     ${cli_check_out}=    Download And Check Flash Image
     ...    ${MECHECK_NO_ME_URL}
     ...    ${TRUE}
+    ...    @{regions_to_check}
     Should Not Contain    ${cli_check_out.stderr}    ${EXPECTED_STDERR_FAILURE_STRING}
 
 Test Flash Check - Complete image but DRY check
     [Documentation]    Check image containing descriptor and ME region in
     ...    dry mode.
+    @{regions_to_check}=    Create List    me
     ${cli_check_out}=    Download And Check Flash Image
     ...    ${MECHECK_ME_URL}
     ...    ${TRUE}
+    ...    @{regions_to_check}
     Should Not Contain    ${cli_check_out.stderr}    ${EXPECTED_STDERR_FAILURE_STRING}
     Should Contain    ${cli_check_out.stdout}    ${EXPECTED_STDOUT_SUCCESS_STRING}